Accept - as --input to transcribe from stdin - #2061
Open
Kayvan-Zahiri wants to merge 1 commit into
Open
Conversation
vosk-transcriber could not be piped into, so 'ffmpeg ... -f wav - |
vosk-transcriber -i -' failed the Path.exists() check before reaching
ffmpeg. Passing - now maps the ffmpeg input URL to pipe:0 and builds a
single task, matching how ffmpeg and whisper spell stdin.
Also format the missing-input message, which printed the literal text
{args.input} rather than the path.
Closes alphacep#2031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2031.
vosk-transcribercould not be piped into. The reported commandfailed at the
Path(args.input).exists()check, so ffmpeg was never reached andthe writer got a broken pipe.
-as--inputnow maps the ffmpeg input URL topipe:0and builds a singletask, which is how ffmpeg and whisper spell stdin.
-nostdinstays: it onlystops ffmpeg reading interactive commands and does not affect an explicit
-i pipe:0(checked against ffmpeg 8.0.1, byte-identical output either way).Also formatted the missing-input message, which printed the literal
{args.input}instead of the path. That is visible in the issue's own output.Verified with
vosk-model-small-en-us-0.15on a 16 kHz mono WAV:-i file.wav(control)the quick brown fox jumps over the lazy dogffmpeg ... | -i --i -with-o out.txt-i -with-t srt