Skip to content

feat(language): add support for .ipynb files - #980

Merged
lizhengfeng101 merged 4 commits into
alibaba:mainfrom
wu21-web:ipynb
Aug 18, 2026
Merged

feat(language): add support for .ipynb files#980
lizhengfeng101 merged 4 commits into
alibaba:mainfrom
wu21-web:ipynb

Conversation

@wu21-web

Copy link
Copy Markdown
Contributor

Description

Add support for .ipynb files, as a co-extension of .py because .ipynb is mostly python source code, and its markdown content doesn't need a review.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)
  • Documentation update
  • CI / Build / Tooling

How Has This Been Tested?

  • make test passes locally
  • Manual testing (describe below)

Checklist

  • My code follows the project's coding style (go fmt, go vet)
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if applicable)
  • I have signed the CLA

Related Issues

None

@github-actions

Copy link
Copy Markdown
Contributor

OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s).

@wu21-web
wu21-web marked this pull request as ready for review August 17, 2026 10:55
Jupyter writes autosave copies of a notebook into a sibling
.ipynb_checkpoints/ directory. Now that .ipynb is in the extension
allowlist, an accidentally committed checkpoint would be reviewed as a
regular file and produce comments duplicating those on the real
notebook. Exclude the directory by default, alongside the other
tool-generated artifacts.
@wu21-web

Copy link
Copy Markdown
Contributor Author

Thank you!

@lizhengfeng101 lizhengfeng101 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhengfeng101
lizhengfeng101 merged commit 24c2dd0 into alibaba:main Aug 18, 2026
13 checks passed
@wu21-web
wu21-web deleted the ipynb branch August 18, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants