Skip to content

feat(providers): add AWS Bedrock as a built-in provider with native SigV4 auth #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhengfeng101 merged 9 commits into from
Aug 20, 2026
Merged

feat(providers): add AWS Bedrock as a built-in provider with native SigV4 auth #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3263862
feat(providers): add AWS Bedrock as a built-in provider
cru-Luis-Rodriguez Aug 3, 2026
b4c7705
feat(config): configure and diagnose an ambient-auth provider from th…
cru-Luis-Rodriguez Aug 3, 2026
0b01ab3
fix(bedrock): correct bearer-token precedence, error triage, and mode…
cru-Luis-Rodriguez Aug 3, 2026
158cc13
fix(bedrock): honour an entry-level protocol override for ambient auth
cru-Luis-Rodriguez Aug 3, 2026
68f19ab
build(deps): bump aws-sdk-go-v2 to clear GO-2026-5764
cru-Luis-Rodriguez Aug 4, 2026
a6933d4
fix(bedrock): correct error triage, ambient credential handling, and …
cru-Luis-Rodriguez Aug 18, 2026
f6d8f4e
docs(pages): document the bedrock provider in all four locales
cru-Luis-Rodriguez Aug 18, 2026
eee10b5
Merge remote-tracking branch 'github/main' into feat/bedrock-provider
lizhengfeng101 Aug 19, 2026
d117fdb
fix(bedrock): clear stale AWS settings on protocol switch, bound conf…
lizhengfeng101 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cmd/opencodereview/apply_provider_field_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func TestApplyProviderField(t *testing.T) {
{"extra_body", `{"k":1}`, func(e ProviderEntry) bool { return e.ExtraBody["k"] != nil }},
}
for _, c := range cases {
if err := applyProviderField(&e, c.field, "providers.p."+c.field, c.value); err != nil {
if err := applyProviderField("p", &e, c.field, "providers.p."+c.field, c.value); err != nil {
t.Fatalf("field %q: %v", c.field, err)
}
if !c.check(e) {
Expand All @@ -34,20 +34,20 @@ func TestApplyProviderField(t *testing.T) {

t.Run("protocol validated and normalized", func(t *testing.T) {
var e ProviderEntry
if err := applyProviderField(&e, "protocol", "providers.p.protocol", "openai"); err != nil {
if err := applyProviderField("p", &e, "protocol", "providers.p.protocol", "openai"); err != nil {
t.Fatalf("valid protocol: %v", err)
}
if e.Protocol == "" {
t.Error("protocol not set")
}
if err := applyProviderField(&e, "protocol", "providers.p.protocol", "not-a-protocol"); err == nil {
if err := applyProviderField("p", &e, "protocol", "providers.p.protocol", "not-a-protocol"); err == nil {
t.Error("expected error for invalid protocol")
}
})

t.Run("auth_header normalized", func(t *testing.T) {
var e ProviderEntry
if err := applyProviderField(&e, "auth_header", "providers.p.auth_header", "x-api-key"); err != nil {
if err := applyProviderField("p", &e, "auth_header", "providers.p.auth_header", "x-api-key"); err != nil {
t.Fatalf("valid auth header: %v", err)
}
if e.AuthHeader == "" {
Expand All @@ -57,21 +57,21 @@ func TestApplyProviderField(t *testing.T) {

t.Run("auth_header rejects unsupported value", func(t *testing.T) {
var e ProviderEntry
if err := applyProviderField(&e, "auth_header", "providers.p.auth_header", "cookie"); err == nil {
if err := applyProviderField("p", &e, "auth_header", "providers.p.auth_header", "cookie"); err == nil {
t.Error("expected error for unsupported auth header")
}
})

t.Run("extra_body rejects invalid JSON", func(t *testing.T) {
var e ProviderEntry
if err := applyProviderField(&e, "extra_body", "providers.p.extra_body", "{bad"); err == nil {
if err := applyProviderField("p", &e, "extra_body", "providers.p.extra_body", "{bad"); err == nil {
t.Error("expected JSON error")
}
})

t.Run("extra_headers parsed", func(t *testing.T) {
var e ProviderEntry
if err := applyProviderField(&e, "extra_headers", "providers.p.extra_headers", "X-A=1"); err != nil {
if err := applyProviderField("p", &e, "extra_headers", "providers.p.extra_headers", "X-A=1"); err != nil {
t.Fatalf("valid extra headers: %v", err)
}
if len(e.ExtraHeaders) == 0 {
Expand All @@ -81,7 +81,7 @@ func TestApplyProviderField(t *testing.T) {

t.Run("unknown field returns error", func(t *testing.T) {
var e ProviderEntry
if err := applyProviderField(&e, "bogus", "providers.p.bogus", "x"); err == nil {
if err := applyProviderField("p", &e, "bogus", "providers.p.bogus", "x"); err == nil {
t.Error("expected error for unknown field")
}
})
Expand Down
Loading
Loading