refactor: remove one-click profiles system#113
Conversation
Profiles conflated model selection (a curated catalog that goes stale) with resource sizing (already handled independently by per-actor preflight, which sizes any models.yaml regardless of origin). Consumers like modelship-home-assistant can ship their own hardcoded model tiers and drive modelship via plain YAML, keeping that opinion out of the server. Removes MSHIP_MODEL_STACK/--model-stack, the profiles package, and its tests; hardware detection itself (modelship/preflight/) is untouched.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request completely removes the one-click model profiles feature (--model-stack / MSHIP_MODEL_STACK) from Modelship. This includes deleting the profile generation, catalog, selector, and budget-reading modules, removing the associated integration and unit tests, updating the documentation, and cleaning up the CLI argument parsing and configuration resolution logic. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Profiles conflated model selection (a curated catalog that goes stale) with resource sizing (already handled independently by per-actor preflight, which sizes any models.yaml regardless of origin). Consumers like modelship-home-assistant can ship their own hardcoded model tiers and drive modelship via plain YAML, keeping that opinion out of the server. Removes MSHIP_MODEL_STACK/--model-stack, the profiles package, and its tests; hardware detection itself (modelship/preflight/) is untouched.