[docs-agent] Add Swap tokens section to wallets nav to fix live 404s - #1650
Merged
Merged
Conversation
🔗 Preview Mode
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0e79ce26f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The same-chain `swap-tokens` and `cross-chain-swap-tokens` pages under `content/wallets/pages/transactions/` are not listed in `content/docs.yml`, so both live URLs return 404 even though the underlying API is still supported (Alpha, live for all teams since Oct 2025 per @jakehobbs). Add a `Swap tokens` subsection under Wallets > Transactions with Same-chain and Cross-chain child pages so both routes render again. Requested-by: @dslovinsky
alchemy-bot
force-pushed
the
docs/remove-token-swaps-links
branch
from
September 23, 2026 22:16
b0e79ce to
ff47b3e
Compare
dslovinsky
previously approved these changes
Sep 23, 2026
github-actions
Bot
dismissed
dslovinsky’s stale review
September 23, 2026 22:29
@dslovinsky you are listed as the originator of this docs request (via the Requested-by trailer on a docs-agent commit). Per the docs-agent self-review policy, the originator can't approve their own request. Please ask another team member to review.
vahnag
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on the Slack thread: the same-chain Swap API is NOT deprecated (@jakehobbs confirmed it's been live for all teams since Oct 2025, ~16 teams using it in the past week). The actual bug @kennethngo-alch reported is that
/docs/wallets/transactions/swap-tokensand/docs/wallets/transactions/cross-chain-swap-tokensboth return 404 on the live site.Root cause: the two MDX files exist on disk at
content/wallets/pages/transactions/swap-tokens/index.mdxandcontent/wallets/pages/transactions/cross-chain-swap-tokens/index.mdx, but neither is registered incontent/docs.yml, so Fern doesn't route to them even though inbound links (wallets index card, transactions overview table, React quickstart bullet, cross-chain guide inline reference) all point at those URLs.Verified against live:
Fix
Added a
Swap tokenssubsection under Wallets > Transactions incontent/docs.yml, placed right afterSend transactions, with two child pages (Same-chain swaps,Cross-chain swaps) mapped to the existing MDX files. No content edits — just nav registration.Diff
History
Original PR intent (removing all inbound links) was based on Ava's initial "yes deprecated" note. That was reversed later in the thread once @jakehobbs shared usage numbers, so the removal commit has been force-pushed away and this PR now instead unblocks the 404s.
Requested by
@dslovinsky (via Slack thread)