perf(build): accelerate AIR lowering and reuse Go cache - #474
Merged
Conversation
Canonically order AIR discovery and generated Go module metadata so identical builds produce stable workspaces. Restart generated temporary names in each lexical declaration scope to prevent unrelated functions from renumbering output.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Warm local builds:
For Tinear, AIR lowering dropped from ~6.18s to ~2.05s. Once generated output became stable, the Go stage dropped from ~3.05s to ~0.35s.
Two identical Tinear builds changed 0/79 generated Go files and no generated workspace files, compared with 62/79 changed Go files before canonicalization.
Validation
go test ./... -count=1go test -race ./... -count=1gopls checkon changed Go filesgit diff --check