Point Google Flights at airline PNG logos#23
Open
hqhq1025 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Google Flights seed data to point at PNG airline logo assets instead of missing SVG paths.
The matching HF asset PR adds all 23 airline logo files referenced by the seeded flights:
google_flights.tar.gzad4535ca0b30d19844d6d4656c1dc857379e9876febaa708c5d292cffb42f7bcLogo source pattern checked for every seeded airline:
Verification
200 image/png.sites/google_flights/static/images/airlines/*.pngand have PNG signatures.python3 -m py_compile sites/google_flights/app.py sites/google_flights/seed_data.pygit diff --check./scripts/extract_assets.sh /tmp/webharbor-google-flights-assets google_flights.Fixes #22.