[issue1228] alternative precondition choice functions for LM-Cut - #301
[issue1228] alternative precondition choice functions for LM-Cut#301PLauerRocks wants to merge 3 commits into
Conversation
| const std::shared_ptr<AbstractTask> &task, bool cache_estimates, | ||
| const std::string &description, utils::Verbosity verbosity); | ||
| const std::string &description, utils::Verbosity verbosity, | ||
| bool use_goal_zone_detection, bool use_border_detection); |
There was a problem hiding this comment.
minor inconsistency with the rest of the code base
parameter order for components should be
1st task,
2nd parameters specific for this component
3rd parameters for this component type
In you case this should be
const std::shared_ptr<AbstractTask> &task,
bool use_goal_zone_detection, bool use_border_detection,
bool cache_estimates, const std::string &description, utils::Verbosity verbosity);
| A proposition is on the border of the goal zone if it can not be achieved by | ||
| operators with zero cost. | ||
| */ | ||
| static bool is_border(const RelaxedProposition *prop) { |
There was a problem hiding this comment.
is_border sounds like you answer whether or not the proposition is a/the border.
But the comment says it is answering whether it is on the border. So i'd suggest to call the function is_on_border.
There was a problem hiding this comment.
I'm going one step further and have a question about the comment itself. What's the connection to the goal zone? In the implementation, I see none... It just checks whether all operators achieving prop have a non-zero cost or not.
Also, regarding the comment itself: it's not clear to me how prop being an effect of only non-zero cost operators prevents it from being in the goal zone. Doesn't the goal zone contain all propositions which may reach goal propositions through only zero-cost operators? So why does it matter how prop is reached when the goal zone definition cares about what can be reached from prop at zero cost.
This is a pull request for issue1228.
Open questions: