Issue1223 - #298
Conversation
A task consists of a domain file and a problem file.
roeger
left a comment
There was a problem hiding this comment.
I had a look at the pull request and only have two small comments.
But wouldn't it make sense to split this into two separate pull requests, one for the renaming in the translator and one for the translator option documentation?
| except Exception: | ||
| pass | ||
|
|
||
| return f"### {name}\n{help_text}\n" |
There was a problem hiding this comment.
This leads to a very ugly table of contents on the right-hand side, where the options are listed with their parameters (and truncated).
Can we augment the subheadings with a short version for the toc? For example:
### `--invariant-generation-max-time INVARIANT_GENERATION_MAX_TIME` {: data-toc-label="--invariant-generation-max-time"}
There was a problem hiding this comment.
I like the idea of having shorter names in the table of contents but I do not know how we could implement this (probably because I do not know how the website generates the table of contents).
There was a problem hiding this comment.
That's why I gave the example. I just added the corresponding commit. @FlorianPommerening or @grucla If you think this change is ok, you can from my side merge the pull request.
There was a problem hiding this comment.
I'm fine with merging as well.
We said on Discord that we would treat the renaming as drive-by clean-up unless it needs more discussion. Do you think it does? |
I don't think it is controversial but it feels like half of the change set. |
Fine with me, but in this case I suggest we go ahead with this issue before doing the renaming. We'll have to cherry-pick the commits that do the renaming from this branch to a new branch and revert them here. I would treat the renaming as not in scope of the sprint story if we don't do it as "drive-by". |
|
Fine with me. |
|
I reverted the changes to the translator here and moved them into a separate PR #300. |
Adds documentation for the translator options