Fixing FormInputwithAddon with no click#114
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d238a60 to
02da9b1
Compare
jules-exel
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://agilitycms.atlassian.net/browse/PROD-1038
The problem
Somewhere along the way, the plenum component
FormInputWithAddonwith the onClick prop failed to propagate the click event back up to its parent.The fix
TablerIcon.tsx — Added ...rest to the destructure and spread it onto <i {...rest}>, so onClick, onMouseDown, and any other HTML attributes now reach the DOM element.
FormInputWithAddons.tsx — The trail icon section now branches on trailIcon?.onClick:
With onClick: renders a that calls e.preventDefault() then the handler, so the click fires correctly without form-submission side effects or focus-stealing.
Without onClick: falls through to the original path, preserving the existing click-to-focus behaviour.
To test