Repository navigation
e2e: remove dead helpers and the broken verify-egress-demo.sh - #2902
Open
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Open
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Conversation
hack/verify-egress-demo.sh is unreferenced and cannot pass since the
egress gateway began enforcing EgressPolicy: it never creates a policy,
so the actor gets no tunnel. demos/egress/test-egress.sh covers the same
path. FColorf and FColorfln have no callers, fixtureSubstitutions sets a
${TEMPLATE_TRUST_BUNDLE} placeholder no pool manifest carries (the
template renderer sets its own), and two suites wrap RunTestMain in
helpers that do nothing.
hack/cleanup-e2e.sh failed under bash 3.2's nounset when no context was
given, because it expanded an empty kubectl_args array.
The security suite's runbook names the real worker container, labels
and paths, and no longer says a failed run keeps its namespaces: they
come from fixture manifests whose cleanup runs pass or fail. Smaller
doc fixes: a fixture name in the e2e README, a typo, a stale fixture
comment, and env_test uses t.Setenv.
Bowei Du (bowei)
approved these changes
Oct 19, 2026
Bowei Du (bowei)
enabled auto-merge
October 19, 2026 21:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes hack/verify-egress-demo.sh (unreferenced, and it can't pass since policy enforcement because it never creates a policy; demos/egress/test-egress.sh covers the same path), unused e2e helpers and a placeholder no manifest carries, fixes hack/cleanup-e2e.sh on macOS bash when no context is set, and corrects the security suite runbook.
Split out of #2166.