Repository navigation
atenet: drop dead router code and share one ingress listener builder - #2896
Open
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Open
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Conversation
extproc.Server kept a port it never read and a Queries wrapper the status page can get from Recorder(); QueryRecorder.Get walks the ring in one loop and has its first test. The ingress package loses actorNotFoundErr and DefaultParkedRequestConfig, which nothing calls, and mapResumeError's three identical 503 cases become one. The statusz template is parsed once instead of on every request. The four ingress listener builders in xds.go share one ingressListener helper and build the same listeners. Tests: synctest replaces real sleeps in the drain-ordering and resumer backoff tests, and the health timeout test shrinks the timeout instead of waiting it out. The xDS tests share publishedSnapshot, currentSnapshot and listenerHCM instead of copying them, the status test's CA comes from internal/localca, and the ingress tests reuse the resumer's mock client. cmd/atenet/README.md now describes the upstream CONNECT path the router takes by default and lists sdsmint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Router cleanup, no behavior change: drop the unused extproc port and Queries,
actorNotFoundErrandDefaultParkedRequestConfig, merge three identical 503 cases inmapResumeError, parse the statusz template once, and build the four ingress listeners with one helper. Tests use synctest instead of sleeping and share the snapshot/HCM helpers. The atenet README now describes the default upstream CONNECT path.Split out of #2166.