Repository navigation
atenet-egress: drop dead code and stale comments in the egress handler - #2895
Open
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Open
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Lior Lieberman (LiorLieberman) wants to merge 1 commit into
Conversation
authenticateActorCertificate already returns a resources.ActorRef, so handleConnect no longer copies it into a second one, and GetActor takes ref.ToObjectRef(). mapCredentialProviderError loses a NotFound and PermissionDenied case that returned the same 403 as its default. Comments said credential injection runs only on the MITM leg and that a rule needing a credential is skipped when no provider is configured; it runs on both request legs and such a request is denied. sdsmint's comments named the removed certauth.Signer. Tests: synctest replaces the real-time polls in the policy cache cancel test and the canceled-caller test, the handler's test CA comes from internal/localca, and sdsmint's stream tests register their teardown with t.Cleanup instead of a defer in each test.
Lior Lieberman (LiorLieberman)
added
the
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanups in the egress handler and sdsmint, no behavior change: drop a duplicate ActorRef and a credential-error case identical to the default, fix comments that still say injection is MITM-leg only or skipped without a provider (it's denied), and use synctest instead of real-time polls in the policy cache tests.
Split out of #2166.