Repository navigation
atelet: Wait for superseded uploads to stop - #2833
Draft
Michelle Au (msau42) wants to merge 1 commit into
Draft
Michelle Au (msau42) wants to merge 1 commit into
Michelle Au (msau42) wants to merge 1 commit into
Conversation
Michelle Au (msau42)
force-pushed
the
wait-superseded-uploads
branch
2 times, most recently
from
October 18, 2026 19:36
c0d92bc to
d429c7e
Compare
Michelle Au (msau42)
force-pushed
the
wait-superseded-uploads
branch
from
October 19, 2026 18:31
d429c7e to
18ce4d8
Compare
Bowei Du (bowei)
added
area/node
area/reliability
area/storage
kind/bug
Michelle Au (msau42)
marked this pull request as draft
October 19, 2026 19:38
Collaborator
Author
|
Moving to draft as it currently depends on #2890 |
2 tasks
Michelle Au (msau42)
force-pushed
the
wait-superseded-uploads
branch
from
October 19, 2026 23:53
18ce4d8 to
5a91211
Compare
When a Checkpoint with an immediate upload, or a PromoteSnapshot, makes a snapshot durable, atelet now cancels any upload of an older snapshot still in progress and waits for it to stop before returning. Terminate likewise waits for the actor's upload or detach in progress to stop, and keeps new ones from starting while it runs. A PromoteSnapshot or Terminate retried meanwhile waits too. As during a PromoteSnapshot, no background upload starts while a Checkpoint with an immediate upload runs. Once the control plane learns that a newer snapshot is durable, or has terminated the actor, atelet is no longer uploading an older snapshot in the background, so the control plane can delete its objects. The canceled upload now deletes the older snapshot's local copy even while that Checkpoint or PromoteSnapshot is in progress. Only a Run or Restore in progress, which may read any local snapshot, keeps it.
Michelle Au (msau42)
force-pushed
the
wait-superseded-uploads
branch
from
October 20, 2026 01:17
5a91211 to
dbe5f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Checkpoint with an immediate upload, or a PromoteSnapshot, makes a snapshot durable, atelet now cancels any upload of an older snapshot still in progress and waits for it to stop before returning. Terminate likewise waits for the actor's upload or detach in progress to stop.
Once the control plane learns that a newer snapshot is durable, or has terminated the actor, nothing on the node is still writing an older snapshot's objects, so the control plane can delete them.
Part of #2069 and #2571