Repository navigation
ateapi: ActorStatus.state_transition_time records when the state last changed - #2647
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Davanum Srinivas (dims) wants to merge 2 commits into
Conversation
Davanum Srinivas (dims)
changed the title
Davanum Srinivas (dims)
marked this pull request as ready for review
October 14, 2026 14:13
Davanum Srinivas (dims)
force-pushed
the
actor-state-transition-time
branch
3 times, most recently
from
October 17, 2026 01:45
3c2e5ce to
c60c79e
Compare
ActorStatus.state_transition_time is stamped on every state change and at creation; `kubectl ate get actors` shows it as IN STATE. update_time moves on every write, so time in a state was not knowable.
The whole-actor comparisons list the server-stamped fields to skip; the new timestamp is one of them. Create asserts it is set.
Davanum Srinivas (dims)
force-pushed
the
actor-state-transition-time
branch
from
October 18, 2026 21:20
c60c79e to
3d68264
Compare
Bowei Du (bowei)
added
area/api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubectl ate get actorsnow shows how long each actor has been in its current state in anIN STATEcolumn. A newstatus.state_transition_timefield records state changes;update_timecannot provide this because it changes on every write.go test -raceon controlapi, the kubectl-ate printer and apivalidation;go vet; hack/verify/codegen.sh and hack/verify/proto-fmt.sh.