Repository navigation
Duration histograms reach 30 minutes; parked and canceled resume outcomes are named - #2642
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Davanum Srinivas (dims) wants to merge 2 commits into
Conversation
Collaborator
Author
|
trying to re-trigger the tests to overcome the flake |
Davanum Srinivas (dims)
changed the title
Davanum Srinivas (dims)
marked this pull request as ready for review
October 14, 2026 14:13
Bowei Du (bowei)
added
area/network
area/node
area/observability
kind/feature
Davanum Srinivas (dims)
force-pushed
the
metrics-buckets
branch
3 times, most recently
from
October 17, 2026 01:48
72bc77f to
6e2d625
Compare
Route, parking-wait, lifecycle and snapshot-phase histograms stopped at 30 s or 60 s, so parked waits and large restores all landed in +Inf.
ate.router.resume put budget exhaustion, lot rejection, client cancellation and real failures all under unknown. Add parked_exhausted, parked_rejected and canceled; unknown now means a failed resume or a direction that resumes nothing.
Davanum Srinivas (dims)
force-pushed
the
metrics-buckets
branch
from
October 18, 2026 21:09
6e2d625 to
705bbfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends duration histogram buckets to 30 minutes so long request waits and snapshot operations can be measured beyond the previous 30–60 second limits. Router resume metrics now distinguish exhausted parking budgets (
parked_exhausted), a full parking lot (parked_rejected), and canceled requests (canceled) instead of grouping them underunknown.go test -raceon atelet, extproc, ingress and ateattr;go vet; hack/verify/metrics.sh.