Repository navigation
ateworker-gvisor: reuse the checkpoint image left by a cancelled attempt - #2491
Closed
Davanum Srinivas (dims) wants to merge 1 commit into
Closed
Davanum Srinivas (dims) wants to merge 1 commit into
Davanum Srinivas (dims) wants to merge 1 commit into
Conversation
Davanum Srinivas (dims)
marked this pull request as ready for review
October 12, 2026 13:24
Davanum Srinivas (dims)
force-pushed
the
ateom-checkpoint-reuse
branch
3 times, most recently
from
October 13, 2026 22:21
3613722 to
1184d85
Compare
Collaborator
|
Julian Gutierrez Oschmann (@juli4n) who worked on Idempotency lately |
Davanum Srinivas (dims)
force-pushed
the
ateom-checkpoint-reuse
branch
4 times, most recently
from
October 16, 2026 12:47
ba5c588 to
0c26755
Compare
Davanum Srinivas (dims)
changed the title
Davanum Srinivas (dims)
force-pushed
the
ateom-checkpoint-reuse
branch
2 times, most recently
from
October 18, 2026 21:03
99ea6c1 to
7cce01a
Compare
Bowei Du (bowei)
added
area/gvisor
area/reliability
area/storage
kind/bug
Davanum Srinivas (dims)
force-pushed
the
ateom-checkpoint-reuse
branch
8 times, most recently
from
October 24, 2026 11:39
1b7a59d to
75f0d2a
Compare
A retried CheckpointWorkload ran `runsc checkpoint` against a sandbox the first attempt had already checkpointed and stopped, got exit 128 and crashed the actor. The first attempt had been cancelled by its caller during the teardown. Reuse the image when it exists and the pause container no longer runs. cmdState now returns the container's status.
Davanum Srinivas (dims)
force-pushed
the
ateom-checkpoint-reuse
branch
from
October 26, 2026 15:19
75f0d2a to
0a3adac
Compare
Collaborator
|
Thanks Davanum Srinivas (@dims)! #3015 (merged) covers this case: when a retried CheckpointWorkload finds the workload gone, it answers from a completion marker that the worker writes only after all snapshot files are written. #2623 (merged) clears partial files before a new attempt, and since it runs first, this PR's check no longer finds the earlier image. Please see more details in #2836. |
Collaborator
Author
|
Chenyi Wang (@chw120) thank you! one PR less for me to think about and rebase :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retried
CheckpointWorkloadranrunsc checkpointagainst a sandbox the first attempt had already checkpointed and stopped, and crashed the actor.checkpoint.imgexists and the pause container is gone or stopped.cmdStatereturns the container's status.The detached post-checkpoint teardown this PR carried landed with #1917.
go test -race ./cmd/ateworker-gvisor/...on linux, lint clean.