Repository navigation
envoy: fix one connection per downstream plus cleanups - #2213
Merged
Bowei Du (bowei) merged 2 commits intoOct 6, 2026
Merged
Conversation
Lior Lieberman (LiorLieberman)
requested review from
Bowei Du (bowei) and
yanavlasov
October 5, 2026 18:58
| # One CONNECT per connection: the filter state internal_upstream copies | ||
| # belongs to the tunnel this connection was made for, and a reused | ||
| # connection would carry it into the next tunnel. | ||
| # One pool per tunnel. A pool gives every connection it opens the |
Collaborator
There was a problem hiding this comment.
Ok with this change, but as I understand, this still seems a bit fragile.
Collaborator
There was a problem hiding this comment.
Yes, I'm working to make it more efficient
Bowei Du (bowei)
approved these changes
Oct 5, 2026
Bowei Du (bowei)
approved these changes
Oct 5, 2026
Bowei Du (bowei)
enabled auto-merge
October 5, 2026 19:54
Collaborator
|
Lior Lieberman (@LiorLieberman) do you have e2e tests for this change? |
Collaborator
Author
you mean beyond TestEgressManifestsGiveEachTunnelItsOwnInnerPool ? |
Collaborator
Yes, e2e tests would be good. I can add it to my PR |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where connection pool and state was reused in a wrong way that caused wrong policy evaluation.
Also, sets a 30s TCP idle timeout on
mitm_internal. A pool now belongs to a single tunnel, so any connection its tunnel leaves behind will never be used again. Without the setting, Envoy keeps that pool for its 10-minute default.Fixes #<issue_number_goes_here>