Added late loan count on admin page and main page - #709
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
=======================================
Coverage 50.98% 50.98%
=======================================
Files 168 168
Lines 3789 3789
=======================================
Hits 1932 1932
Misses 1857 1857 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Luhmos
approved these changes
Sep 7, 2026
Luhmos
left a comment
Luhmos
left a comment
Member
There was a problem hiding this comment.
I think I would have reworded it to something like "n prêts en cours, dont x en retard." to be just a bit clearer, apart from that lgtm!
cotanoine
approved these changes
Sep 7, 2026
cotanoine
left a comment
cotanoine
left a comment
Contributor
There was a problem hiding this comment.
Why put .toLowerCase in every use of your new string constants instead of directly setting it in lowercase ?
Marc-Andrieu
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added late loan count on admin page and main page.
So it's easier to see how many loans are late, and how many students need to be reminded.
Summary
...
Issues/PR dependencies
Issues to be resolved
Required PRs
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
//Comments