Conversation
Marc-Andrieu
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dark/core #675 +/- ##
=============================================
- Coverage 50.87% 50.61% -0.27%
=============================================
Files 169 169
Lines 3819 3839 +20
=============================================
Hits 1943 1943
- Misses 1876 1896 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Marc-Andrieu
marked this pull request as ready for review
May 5, 2026 18:09
97 tasks
Marc-Andrieu
force-pushed
the
dark/amap
branch
3 times, most recently
from
May 10, 2026 17:26
b834060 to
b0a6106
Compare
…ors is to be done
Marc-Andrieu
added a commit
that referenced
this pull request
Aug 7, 2026
# Description ## Summary <!--BRIEF description: DON'T EXPLAIN the code: JUSTIFY what this PR is for!--> See #671 NB: many color declarations will have to be removed (dead code) or renamed to match again their actual use for maintainability. PS: not a big fan of the color combination on screenshot n°2 (the rest is fine, legible text, good contrasts like in the light theme) <img height="400" alt="image" src="https://github.com/user-attachments/assets/98baf029-448c-4bc2-81eb-00eb8f89a011" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/87061203-988e-4cf7-bc91-f19cc13b7e2f" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/9ade49ab-db8a-48d9-8297-bf312c52d4ac" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/95b23647-f2a7-448a-89e9-32315830f1c5" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/10d6db89-2e13-4de5-bae7-4f831520b0b1" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/24833a4a-1a56-479e-a164-9e7d4aa5fc80" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/4babd9dd-0152-4f83-a4cd-8a7019cfaf83" /> <img height="400" alt="image" src="https://github.com/user-attachments/assets/41d6ca21-e688-48c2-a13b-a3b4b38288da" /> ## Required PRs Depends on #671 ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] amap - [x] components - [x] order_ui - [x] product_ui - [x] pages - [x] admin_page - [x] account_handler - [x] adding_user - [x] adding_user_container - [x] admin_page - [x] cash_container - [x] delivery_handler - [x] delivery_ui - [x] product_handler - [x] user_cash_ui_layout - [x] user_cash_ui - [x] delivery_pages - [x] add_edit_delivery_cmd_page - [x] product_ui_check - [x] detail_delivery_page - [x] detail_page - [x] order_detail_ui - [x] product_detail_ui - [x] detail_page - [x] list_products_page - [x] category_page - [x] list_products_page - [x] list_products - [x] page_view_dots - [x] product_choice_button - [x] product_ui_list - [x] web_page_navigation_button - [x] main_page - [x] collection_slot_selector - [x] delivery_section - [x] delivery_ui - [x] main_page - [x] orders_section - [x] presentation_page - [x] product_pages - [x] amap ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch these two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [x] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a local client using a pre-prod backend - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `//` Comments - [ ] No documentation needed </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
See #671
NB: many color declarations will have to be removed (dead code) or renamed to match again their actual use for maintainability.
PS: not a big fan of the color combination on screenshot n°2 (the rest is fine, legible text, good contrasts like in the light theme)
Required PRs
Depends on #671
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
//Comments