Skip to content

Delete revoked payment devices - #832

Closed
Marc-Andrieu wants to merge 3 commits into
mainfrom
myeclpay/delete-revoked
Closed

Marc-Andrieu wants to merge 3 commits into
mainfrom
myeclpay/delete-revoked

Conversation

@Marc-Andrieu

Copy link
Copy Markdown
Member

Close #830

@Marc-Andrieu Marc-Andrieu added question Further information is requested ready for review This PR is ready to be reviewed feat New feature or request payment labels Sep 12, 2025
@codecov

codecov Bot commented Sep 12, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.50%. Comparing base (55d1b94) to head (c3ab76c).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
app/core/myeclpay/endpoints_myeclpay.py 28.57% 5 Missing ⚠️
app/core/myeclpay/cruds_myeclpay.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   85.53%   85.50%   -0.04%     
==========================================
  Files         189      189              
  Lines       14255    14264       +9     
==========================================
+ Hits        12193    12196       +3     
- Misses       2062     2068       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu

Copy link
Copy Markdown
Member Author

Nice for some users
but non-trivial to implement
and at the end of the day it introduces a security issue

@Marc-Andrieu
Marc-Andrieu deleted the myeclpay/delete-revoked branch September 20, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request payment question Further information is requested ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add admin endpoint to delete deactived devices

1 participant