AN-451008 paid-media: add missing title on nested leaf properties#2171
Open
ejsuncy wants to merge 1 commit into
Open
AN-451008 paid-media: add missing title on nested leaf properties#2171ejsuncy wants to merge 1 commit into
ejsuncy wants to merge 1 commit into
Conversation
## Summary Several nested-object leaf properties in the paid-media fieldgroup schemas were missing the `title` keyword (and `description` in most cases). Downstream consumers (CJA Workspace, schema editors, docs) were falling back to the full dot-notation `schemaPath` as the display name — surfacing raw paths like `paidMedia.attributionMetrics.crossDeviceAttribution.devicePathBreakdown.mobileToMobileApp` in the UI instead of a human-readable label. Sibling properties at the same nesting level all have `title` set, so this was an oversight in three inline object definitions, not an intentional pattern. ## Affected fields `components/fieldgroups/paid-media/core-paid-media-attribution-metrics.schema.json` - `xdm:devicePathBreakdown` leaves: `mobileToDesktop`, `desktopToMobile`, `mobileToMobileApp` - `xdm:channelSequence.items`: `channel`, `position`, `weight` `components/fieldgroups/paid-media/core-paid-media-campaign-details.schema.json` - `xdm:dayParting.schedule.items`: `dayOfWeek`, `startHour`, `endHour` ## Backwards compatibility No breaking changes. Only `title` and `description` metadata are added; property names, types, and constraints are unchanged. `npm test` and `npm run validate components/fieldgroups/paid-media` both pass on this branch. Issue: adobe#2170 Jira: AN-451008 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several nested-object leaf properties in the paid-media fieldgroup
schemas were missing the
titlekeyword (anddescriptionin mostcases). Downstream consumers (CJA Workspace, schema editors, docs) were
falling back to the full dot-notation
schemaPathas the display name— surfacing raw paths like
paidMedia.attributionMetrics.crossDeviceAttribution.devicePathBreakdown.mobileToMobileAppin the UI instead of a human-readable label.
Sibling properties at the same nesting level all have
titleset, sothis was an oversight in three inline object definitions, not an
intentional pattern.
Affected fields
components/fieldgroups/paid-media/core-paid-media-attribution-metrics.schema.jsonxdm:devicePathBreakdownleaves:mobileToDesktop,desktopToMobile,mobileToMobileAppxdm:channelSequence.items:channel,position,weightcomponents/fieldgroups/paid-media/core-paid-media-campaign-details.schema.jsonxdm:dayParting.schedule.items:dayOfWeek,startHour,endHourBackwards compatibility
No breaking changes. Only
titleanddescriptionmetadata are added;property names, types, and constraints are unchanged.
npm testandnpm run validate components/fieldgroups/paid-mediabothpass on this branch.
Issue: #2170
Jira: AN-451008
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com