You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds icon.vrt.ts and icon-custom-properties.vrt.ts under components/icon/test/vrt/, covering sizes, labeled/decorative (aria-hidden) usage, forced-colors, and the three --swc-icon-* custom properties.
Motivation and context
Icon had no dedicated VRT suite; this follows the VRT foundation pattern established for button.
Related issue(s)
SWC-2400
Screenshots (if appropriate)
N/A
Author's checklist
I have read the CONTRIBUTING and PULL_REQUESTS documents.
I have reviewed the Accessibility Practices for this feature, see: Aria Practices.
I have added automated tests to cover my changes.
I have included a well-written changeset if my change needs to be published.
I have included updated documentation if my change required it.
Reviewer's checklist
Includes a Github Issue with appropriate flag or Jira ticket number without a link
Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
Automated tests cover all use cases and follow best practices for writing
Validated on all supported browsers
All VRTs are approved before the author can update Golden Hash
Manual review test cases
Storybook VRT stories render correctly
Go to Storybook, Icon/Icon VRT
Open Permutations, Forced colors, and Custom properties
Expect sizes, labeled/decorative icons, and custom-property overrides to render as described
Device review
Did it pass in Desktop?
Did it pass in (emulated) Mobile?
Did it pass in (emulated) iPad?
Accessibility testing checklist
Keyboard: <swc-icon> has no focusable parts; confirm no focus stops occur when tabbing through the Icon/Icon VRT → Permutations story.
Screen reader: 1. Open Icon/Icon VRT → Permutations. 2. Confirm the labeled icon is announced as an image with its label (e.g. "Search"). 3. Confirm the decorative icon is not announced (aria-hidden).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
icon.vrt.tsandicon-custom-properties.vrt.tsundercomponents/icon/test/vrt/, covering sizes, labeled/decorative (aria-hidden) usage, forced-colors, and the three--swc-icon-*custom properties.Motivation and context
Icon had no dedicated VRT suite; this follows the VRT foundation pattern established for button.
Related issue(s)
Screenshots (if appropriate)
N/A
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Icon/Icon VRTPermutations,Forced colors, andCustom propertiesDevice review
Accessibility testing checklist
<swc-icon>has no focusable parts; confirm no focus stops occur when tabbing through theIcon/Icon VRT → Permutationsstory.Icon/Icon VRT → Permutations. 2. Confirm the labeled icon is announced as an image with its label (e.g. "Search"). 3. Confirm the decorative icon is not announced (aria-hidden).