chore(status-light): add VRT coverage - #6620
Conversation
|
03a87a3 to
166d2dc
Compare
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
166d2dc to
ecdfe9e
Compare
ecdfe9e to
c6cb8b7
Compare
5t3ph
left a comment
There was a problem hiding this comment.
For the same reason we don't keep button or badge colors for forced-colors, I don't think we should be keeping them for status light. Reason being that relying on color alone to communicate is a WCAG failure, and we also can't know the intent of those colors out of context.
Can you update the dots to use CanvasText as the background-color for forced-colors mode?
Maybe we also need a ticket to investigate some type of like "retain color" opt-in switch so that contextually colors for status light and maybe badge can be kept for forced-colors, or if we just need to add a demo in our customization docs for how to handle that perhaps.
That makes sense (and was something I hadn't considered). I revised the comments and added the |
134f728 to
60b21ff
Compare
5t3ph
left a comment
There was a problem hiding this comment.
A little more simplification can be done for the forced-colors.
4c1e3b8 to
f32d315
Compare
Description
Adds dedicated
test/vrt/coverage forstatus-light, following thebutton/badgeVRT pattern:status-light.vrt.tscovers every variant (5 semantic + 14 non-semantic) × size, grouped into one row per variant, plus aWrappingrow and aCJK languagerow (status-light.css sets a distinct line-height for:lang(ja/zh/ko));ForcedColorsreuses the full permutation set sinceforced-color-adjust: noneis set on the whole component, so every variant's color survives forced-colors mode rather than collapsing to a system color.status-light-custom-properties.vrt.tscovers reference/override rows for all six documented custom properties (dot-size,dot-color,font-size,line-height,text-to-visual,content-color), withverifyCustomPropertyCoverage()checked against the manifest. No global-styles VRT file is included sincestatus-lighthas no plain-class global stylesheet.Motivation and context
Closes the VRT coverage gap for
status-lightcalled out in SWC-2410.Related issue(s)
Author's checklist
Accessibility testing checklist