Skip to content

fix(infield-button): replace story icons with S2 UI icon paths - #6597

Merged
pfulton merged 2 commits into
mainfrom
rajdeepchandra/fix-infield-button-icon-s2-ui
Aug 10, 2026
Merged

fix(infield-button): replace story icons with S2 UI icon paths#6597
pfulton merged 2 commits into
mainfrom
rajdeepchandra/fix-infield-button-icon-s2-ui

Conversation

@Rajdeepc

@Rajdeepc Rajdeepc commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the four inline SVG icons in swc-infield-button Storybook stories with their correct S2 UI equivalents. The previous icons were either using sharp line-command paths or large 36×36 workflow-icon viewBoxes; this PR switches all four to the S2 UI size-75 style (10×10 viewBox, arc-based rounded ends) that matches the Spectrum 2 visual language.

Icon Before After
Chevron (picker disclosure) Sharp L/Z path, 10×10 viewBox S2 UI Chevron size-75, rotate: 90deg to point down
Add (stepper increment) 1st-gen workflow path, 36×36 viewBox S2 UI Add size-75, 10×10 viewBox
Dash (stepper decrement) 1st-gen workflow path, 36×36 viewBox S2 UI Dash size-75, 10×10 viewBox
Cross (search clear) 1st-gen workflow path, 36×36 viewBox S2 UI Cross size-75, 10×10 viewBox

No production component code was changed. Only the story icon constants in infield-button.stories.ts are affected.

Motivation and context

A design team reviewer flagged during post-merge review of the swc-infield-button migration that the Storybook story icons did not match the S2 visual language — specifically that the chevron lacked the rounded arc ends expected in Spectrum 2. The other three icons were also sourced from 1st-gen workflow icon paths with an incorrect 36×36 viewBox, making them render at a different weight and proportion than intended.

The correct paths are sourced from the internal ui-icons package (Chevron.ts, Add.ts, Dash.ts, Cross.ts at size 75).

Related issue(s)

Screenshots (if appropriate)

Reviewers: the visual difference is most visible in the Anatomy, Overview, and States stories — the chevron now has visibly rounded ends, and the add/dash/cross icons are correctly proportioned for the 10×10 slot.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

No changeset is needed — this is a stories-only fix with no changes to the published @adobe/spectrum-wc package API.


Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Icon rendering matches S2 UI visual style

    1. Open the swc-infield-button Storybook stories (Anatomy, Overview, Options > Sizes, States)
    2. Inspect each icon: chevron (picker), cross (search clear), add and dash (stepper)
    3. Confirm all icons have visibly rounded arc ends — no sharp corners on chevron tips, cross arms, or add/dash caps
    4. Confirm the picker chevron points down and is correctly proportioned within the button hit area across all four sizes (S, M, L, XL)
  • No icon sizing or color regressions

    1. In the Sizes story, verify all four sizes render the icon at the expected scale — none overflow the button bounds or appear too small
    2. Toggle the Quiet option on/off in the Playground; confirm icon color still changes correctly with the button state

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

  • Keyboard — No keyboard behavior changes. All swc-infield-button instances in the stories already carry accessible-label; the icon change does not affect the button's accessible name or role. Confirmed no regressions: the button is still excluded from the tab order (tabindex="-1") and is activated only by pointer, matching the component's intended contract.

  • Screen reader — All icons are marked aria-hidden="true". The icon style change is purely visual and produces no change in the screen reader-exposed tree. The accessible-label on each swc-infield-button remains the sole announcement.

All four inline SVG icons now use the S2 UI style (10×10 viewBox, rounded
arc ends) sourced from the ui-icons package, matching the rounded chevron
the design reviewer requested.

- Chevron: S2 UI Chevron size-75 path rotated 90° (clockwise → down) for
  picker disclosure affordance
- Add/Dash/Cross: S2 UI size-75 paths replace the 36×36 workflow icon paths

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Rajdeepc
Rajdeepc requested a review from a team as a code owner August 10, 2026 12:52
@changeset-bot

changeset-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7558f5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rajdeepc Rajdeepc self-assigned this Aug 10, 2026
@Rajdeepc Rajdeepc added bug Something isn't working Status:Ready for review PR ready for review or re-review. Spectrum 2 Issues related to Spectrum 2 labels Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6597

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@Rajdeepc Rajdeepc added the run_vrt Triggers the Chromatic VRT run for 2nd-gen label Aug 10, 2026
@miwha-adobe miwha-adobe self-assigned this Aug 10, 2026
@miwha-adobe
miwha-adobe self-requested a review August 10, 2026 18:13
@pfulton pfulton added Status:Ready for merge PR has 2 approvals, all tests pass, and is ready to merge and removed Status:Ready for review PR ready for review or re-review. labels Aug 10, 2026
@pfulton
pfulton merged commit 5c7c2bf into main Aug 10, 2026
36 checks passed
@pfulton
pfulton deleted the rajdeepchandra/fix-infield-button-icon-s2-ui branch August 10, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working run_vrt Triggers the Chromatic VRT run for 2nd-gen Spectrum 2 Issues related to Spectrum 2 Status:Ready for merge PR has 2 approvals, all tests pass, and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants