fix(infield-button): replace story icons with S2 UI icon paths - #6597
Conversation
All four inline SVG icons now use the S2 UI style (10×10 viewBox, rounded arc ends) sourced from the ui-icons package, matching the rounded chevron the design reviewer requested. - Chevron: S2 UI Chevron size-75 path rotated 90° (clockwise → down) for picker disclosure affordance - Add/Dash/Cross: S2 UI size-75 paths replace the 36×36 workflow icon paths Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Description
Replaces the four inline SVG icons in
swc-infield-buttonStorybook stories with their correct S2 UI equivalents. The previous icons were either using sharp line-command paths or large 36×36 workflow-icon viewBoxes; this PR switches all four to the S2 UI size-75 style (10×10 viewBox, arc-based rounded ends) that matches the Spectrum 2 visual language.L/Zpath, 10×10 viewBoxrotate: 90degto point downNo production component code was changed. Only the story icon constants in
infield-button.stories.tsare affected.Motivation and context
A design team reviewer flagged during post-merge review of the
swc-infield-buttonmigration that the Storybook story icons did not match the S2 visual language — specifically that the chevron lacked the rounded arc ends expected in Spectrum 2. The other three icons were also sourced from 1st-gen workflow icon paths with an incorrect 36×36 viewBox, making them render at a different weight and proportion than intended.The correct paths are sourced from the internal
ui-iconspackage (Chevron.ts,Add.ts,Dash.ts,Cross.tsat size 75).Related issue(s)
Screenshots (if appropriate)
Reviewers: the visual difference is most visible in the Anatomy, Overview, and States stories — the chevron now has visibly rounded ends, and the add/dash/cross icons are correctly proportioned for the 10×10 slot.
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Icon rendering matches S2 UI visual style
swc-infield-buttonStorybook stories (Anatomy, Overview, Options > Sizes, States)No icon sizing or color regressions
Device review
Accessibility testing checklist
Keyboard — No keyboard behavior changes. All
swc-infield-buttoninstances in the stories already carryaccessible-label; the icon change does not affect the button's accessible name or role. Confirmed no regressions: the button is still excluded from the tab order (tabindex="-1") and is activated only by pointer, matching the component's intended contract.Screen reader — All icons are marked
aria-hidden="true". The icon style change is purely visual and produces no change in the screen reader-exposed tree. Theaccessible-labelon eachswc-infield-buttonremains the sole announcement.