Skip to content

🚨DO NOT MERGE🚨 chore: take in and apply tokens snapshot dependency - #6559

Draft
pfulton wants to merge 1 commit into
mainfrom
pfulton/tokens-snapshot-review
Draft

🚨DO NOT MERGE🚨 chore: take in and apply tokens snapshot dependency#6559
pfulton wants to merge 1 commit into
mainfrom
pfulton/tokens-snapshot-review

Conversation

@pfulton

@pfulton pfulton commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fa38b50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pfulton pfulton added the do-not-merge NO MERGE-Y! label Jul 28, 2026
@pfulton pfulton changed the title chore: take in and apply tokens snapshot dependency 🚨DO NOT MERGE🚨 chore: take in and apply tokens snapshot dependency Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6559

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@pfulton pfulton added the skip_vrt Skip VRT build; mark UI Tests green without running Chromatic label Jul 28, 2026
@Deanna-w1

Copy link
Copy Markdown

Thank you!

@pfulton
pfulton force-pushed the pfulton/tokens-snapshot-review branch from 4b0a370 to fa38b50 Compare August 14, 2026 14:25
@pfulton pfulton added run_vrt Triggers the Chromatic VRT run for 2nd-gen and removed skip_vrt Skip VRT build; mark UI Tests green without running Chromatic labels Aug 14, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 31809439659

Warning

No base build found for commit 56fd6ef on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.241%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 39268
Covered Lines: 37993
Line Coverage: 96.75%
Relevant Branches: 6461
Covered Branches: 6017
Branch Coverage: 93.13%
Branches in Coverage %: Yes
Coverage Strength: 460.06 hits per line

💛 - Coveralls

@pfulton pfulton added skip_vrt Skip VRT build; mark UI Tests green without running Chromatic and removed run_vrt Triggers the Chromatic VRT run for 2nd-gen labels Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge NO MERGE-Y! skip_vrt Skip VRT build; mark UI Tests green without running Chromatic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants