Skip to content

Chore/maintenance for 5.2.3 - #3162

Merged
afranken merged 2 commits into
mainfrom
chore/maintenance-for-5.2.3
Sep 19, 2026
Merged

afranken merged 2 commits into
mainfrom
chore/maintenance-for-5.2.3

Conversation

@afranken

@afranken afranken commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Description

  • changelog for 5.2.3
  • SBOM generation fix

Related Issue

N/A

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copilot AI lite review requested due to automatic review settings September 19, 2026 09:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The SBOM workflow contains two unresolved critical issues.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity · 1 Low severity

Open (3)
What changed in this PR

This maintenance PR prepares the 5.2.3 release and updates asynchronous SBOM generation.

Changes:

  • Adds 5.2.3 changelog entries.
  • Replaces the deprecated SBOM action with GitHub API generation and artifact upload.
File Summary
CHANGELOG.md Adds 5.2.3 release notes; capitalize GitHub.com consistently (nit, 3 votes).
.github/​workflows/​sbom.yml Adds asynchronous SBOM generation and upload; critical issues require using POST for report generation (1 vote) and not treating 202 Accepted as completion (3 votes).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/sbom.yml
Comment thread .github/workflows/sbom.yml Outdated
Comment thread CHANGELOG.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The SBOM workflow currently uses GET for generate-report, preventing SBOM generation.

Review effort: Lite
Findings: None

Resolved since last review (3)

@afranken
afranken merged commit 33c6899 into main Sep 19, 2026
8 checks passed
@afranken
afranken deleted the chore/maintenance-for-5.2.3 branch September 19, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants