You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I hit the same thing from the library side while building the CLI. The cause looks like filterVerses being called in only one place: inside the regex branch of src/core/search.ts. The linguistic path never calls it, so suraId, juzId and suraName
are all accepted and then ignored:
search('الله',ctx,{lemma: true,root: true,suraId: 1},{page: 1,limit: 3});// 1880 results, first is 1:1, then 2:7 and 2:8// suraId: 78, juzId: 1 and juzId: 30 all give identical numbers
The same query with isRegex: true filters correctly, which is what pointed me at the branch.
One thing worth deciding early: filterVerses treats the three as a priority chain, suraId
first, then suraName, then juzId, so only one ever applies. If someone passes suraId and juzId together, they probably expect both.
My CLI PR narrows the corpus before calling search() as a local workaround, so it does not
depend on this being fixed. Once your fix lands I will drop that and rely on the library.
Nothing I am doing should collide with you, and I am not touching search.ts or simple-search.ts.
Checking in since there hasn't been an update in a while. Are you still interested in this issue? If I don't hear back, I'll unassign it so someone else can pick it up.
Please accept my apologies for the delay on this task.
I'm still interested in this issue, but I haven't had the time to solve it.
I had an unexpected personal matter to take care of and was away from my computer.
Salam @adelpro , I would like to work on this issue as @laylahammoury mentioned she won't be able to handle it. Could you please assign it to me? Thank you!
Please accept my apologies for the delay on this task. I'm still interested in this issue, but I haven't had the time to solve it. I had an unexpected personal matter to take care of and was away from my computer.
Please assign it to someone else .
Thank you for your patience.
Thanks for you time and for your effort on this project, you re welcome t any time
Salam @adelpro , I would like to work on this issue as @laylahammoury mentioned she won't be able to handle it. Could you please assign it to me? Thank you!
Activity
ibrahimtaha22 commentedon Aug 12, 2026
Hi, I'd like to work on this issue. Could you please assign it to me?
adelpro commentedon Aug 15, 2026
What playground did you work on here, @laylahammoury?
Also, can you take this issue, or should we pass it to @ibrahimtaha22?
adelpro commentedon Aug 15, 2026
And thanks a lot for pointing out this bug, @laylahammoury. Baraka Allahu fik!
laylahammoury commentedon Aug 16, 2026
I used React Playground.
I would like to work on it. Thanks.
adelpro commentedon Aug 16, 2026
Salam @laylahammoury
Your assessment is correct. You can start working on this bug. Please check the juz ID and surah ID.
adelpro commentedon Aug 16, 2026
@ibrahimtaha22 thanks for your interest in this project, you are welcome to contribute, please check available issues or suggest a new one
ibrahimtaha22 commentedon Aug 16, 2026
Thanks, @adelpro I completely understand. I will check the other open issues and see where I can contribute to the project.
MalikMlitat commentedon Aug 17, 2026
Salam @laylahammoury, @adelpro pointed me here from #97, so some notes in case they help.
I hit the same thing from the library side while building the CLI. The cause looks like
filterVersesbeing called in only one place: inside the regex branch ofsrc/core/search.ts. The linguistic path never calls it, sosuraId,juzIdandsuraNameare all accepted and then ignored:
The same query with
isRegex: truefilters correctly, which is what pointed me at the branch.One thing worth deciding early:
filterVersestreats the three as a priority chain,suraIdfirst, then
suraName, thenjuzId, so only one ever applies. If someone passessuraIdandjuzIdtogether, they probably expect both.My CLI PR narrows the corpus before calling
search()as a local workaround, so it does notdepend on this being fixed. Once your fix lands I will drop that and rely on the library.
Nothing I am doing should collide with you, and I am not touching
search.tsorsimple-search.ts.adelpro commentedon Sep 11, 2026
Salam @laylahammoury
Checking in since there hasn't been an update in a while. Are you still interested in this issue? If I don't hear back, I'll unassign it so someone else can pick it up.
laylahammoury commentedon Sep 12, 2026
Salam @adelpro,
Please accept my apologies for the delay on this task.
I'm still interested in this issue, but I haven't had the time to solve it.
I had an unexpected personal matter to take care of and was away from my computer.
Please assign it to someone else .
Thank you for your patience.
ibrahimtaha22 commentedon Sep 12, 2026
Salam @adelpro , I would like to work on this issue as @laylahammoury mentioned she won't be able to handle it. Could you please assign it to me? Thank you!
adelpro commentedon Sep 12, 2026
Thanks for you time and for your effort on this project, you re welcome t any time
Baraka allaho fik
adelpro commentedon Sep 12, 2026
Ok @ibrahimtaha22 you can start working on this issue