Skip to content

[FeatureRequest] Improve JSON Verification #97

Open

Description

@PsychoData

Improve JSON verification so that you will not have duplicate entries, or separate entries across pages that are duplicates

We shouldn't have separate entries on the Admin page and the End-User page that both link to portal.office.com or similar, because this might make them collide later or show duplicate entries

As we work on #91 I think this will become a more apparently issue.

Checks I can think of

  • No Duplicate entries between pages
  • Portal syntax validation
    • Each file in /_data/Portals/*.json should be able to convert as JSON
    • Each file Should be at least 1 Portal Group in each file
      • Each Portal Group should have at least 1 Portal in it
        • Each Portal must have a PrimaryURL Field
          • Each PrimaryURL must resolve as an https:// url (possibly http ok?)
        • Each Portal Must have a Portal Name
        • Each Portal can have up to two SecondaryURL's to show, none is also fine.
          • Each SecondaryURL text is no longer than 8 characters long
          • Each SecondaryURL must resolve as an https:// url (possibly http ok?)
        • Each Portal can have only one Note field
  • Every URL Should be publicly Resolveable? Even if it resolves to a "You must sign in" page
  • Standardize capitalization/punctuation?

Activity

  1. self-assigned this
    on Feb 4, 2021
  2. PsychoData commented on Feb 4, 2021

    @PsychoData
    ContributorAuthor

    Looking into some of this via JSON Schema which I believe may also enable Intellisense in VSCode?
    At the very least, it would enable VS Code yelling at you in the Problems tab that "You cannot put a SecondaryURL field on a PortalGroup" or "You cannot specify two Note properties" et cetera. But the Schema may not work for some things like "No Duplicates"

    Any other checks / tests that would be useful?

  3. adamfowlerit commented on Feb 5, 2021

    @adamfowlerit
    Owner

    No other checks I can think of - the Standarize capitalization/punctuation might be hard as I've been using whatever the portal says it is, which there doesn't seem to be a standard there?

  4. adamfowlerit commented on Sep 18, 2024

    @adamfowlerit
    Owner

    @PsychoData Feel like giving this a shot? All those checks would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions