feat: Add the option of bin counting histograms for the surfaces material maps#5567
Open
dimitra97 wants to merge 5 commits into
Open
feat: Add the option of bin counting histograms for the surfaces material maps#5567dimitra97 wants to merge 5 commits into
dimitra97 wants to merge 5 commits into
Conversation
github-actions
Bot
added
Component - Core
andiwand
reviewed
Jun 10, 2026
andiwand
changed the title
andiwand
reviewed
Jun 10, 2026
| BinnedSurfaceMaterial(const BinUtility& binUtility, | ||
| MaterialSlabVector materialVector, | ||
| double splitFactor = 0., | ||
| std::vector<unsigned int> binCounts = {}, |
Contributor
There was a problem hiding this comment.
for this to be non-breaking the parameter would have to be the last one
| BinnedSurfaceMaterial(const BinUtility& binUtility, | ||
| MaterialSlabMatrix materialMatrix, | ||
| double splitFactor = 0., | ||
| std::vector<std::vector<unsigned int>> binCounts = {}, |
Comment on lines
+147
to
+148
| std::unique_ptr<const ISurfaceMaterial> totalAverage( | ||
| bool recordBinCounts = false); |
Contributor
There was a problem hiding this comment.
I wonder if we really want to pipe everything through the reconstruction abstraction. if these were two different interfaces we could leave the reco untouched
one way out might be to containerize the accumulated material with dynamic columns and trimming that for reconstruction purposes
but all of this is rather long term compared to this change here
cc @asalzburger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility of recording the bin counts optionally and create an extra histogram in the material maps for every mapped surface.
It has been enabled by a flag when estimating the total average material to optionally record the bin counts and pass it in the constructor of the
BinnedSurfaceMaterial(otherwise an empty matrix is passed).It can be useful for statistical studies (how many bins have been mapped with how many hits etc during the material mapping) as a root macro that I have included can show this use case.
I tried to make it as simple as possible and not to affect much clients' side and experiments that already rely on these functions.
--- END COMMIT MESSAGE ---
Tagging @asalzburger @noemina