feat: expose PlotTool configs in .py, add per-layer particleId to tree#5530
Draft
altsybee wants to merge 2 commits into
Draft
feat: expose PlotTool configs in .py, add per-layer particleId to tree#5530altsybee wants to merge 2 commits into
altsybee wants to merge 2 commits into
Conversation
added 2 commits
June 2, 2026 00:40
|
Contributor
andiwand
reviewed
Jun 2, 2026
Comment on lines
+148
to
+153
| /// The particle id of the truth particle that left each measurement. | ||
| /// Outer: one entry per track. Inner: one entry per measurement on | ||
| /// that track, ordered identically to m_measurementVolume / | ||
| /// m_measurementLayer (reverse state order). Sentinel value 0 means | ||
| /// no truth link or no truth inputs configured. | ||
| std::vector<std::vector<std::uint64_t>> m_measurementParticleId; |
Contributor
There was a problem hiding this comment.
I fear this gets a bit into the direction of the RootTrackStatesWriter which I would rather not duplicate in this writer
Comment on lines
+46
to
+80
| namespace { | ||
| /// Tiebreaker for assigning a single particleId to a measurement. | ||
| /// 1) Prefer the track's majority particle if any contributing sim hit | ||
| /// matches it. | ||
| /// 2) Otherwise fall back to the sim hit with the largest deposited | ||
| /// energy. Ties broken by first occurrence. | ||
| /// Returns 0 if the range is empty. | ||
| template <typename Range> | ||
| std::uint64_t pickParticleId(const Range& simHitIndices, | ||
| const ActsExamples::SimHitContainer& simHits, | ||
| const ActsExamples::SimBarcode& majorityParticleId, | ||
| bool haveMajorityParticleId) { | ||
| // Rule 1: prefer the majority particle if any contributor matches. | ||
| if (haveMajorityParticleId) { | ||
| for (const auto& [measIdx, simHitIdx] : simHitIndices) { | ||
| const auto& simHit = *simHits.nth(simHitIdx); | ||
| if (simHit.particleId() == majorityParticleId) { | ||
| return static_cast<std::uint64_t>(majorityParticleId.hash()); | ||
| } | ||
| } | ||
| } | ||
| // Rule 2: fall back to the highest-deposit hit. | ||
| std::uint64_t bestId = 0; | ||
| double bestDeposit = -std::numeric_limits<double>::infinity(); | ||
| for (const auto& [measIdx, simHitIdx] : simHitIndices) { | ||
| const auto& simHit = *simHits.nth(simHitIdx); | ||
| const double dep = simHit.depositedEnergy(); | ||
| if (dep > bestDeposit) { | ||
| bestDeposit = dep; | ||
| bestId = static_cast<std::uint64_t>(simHit.particleId().hash()); | ||
| } | ||
| } | ||
| return bestId; | ||
| } | ||
| } // namespace |
Contributor
There was a problem hiding this comment.
this seems like an alternative approach to truth matching which was extracted into TrackTruthMatcher some time ago to be consistent across all writers. I would discourage us to split this logic again. So I would rather upstream this there but also check against what #5515 is doing
Comment on lines
+27
to
+38
| # Resolution Plots | ||
| ResPlotToolConfig = acts.examples.root.ResPlotToolConfig() | ||
| # Duplication Plots | ||
| DuplicationPlotToolConfig = acts.examples.root.DuplicationPlotToolConfig() | ||
| # Efficiency Plots | ||
| EffPlotToolConfig = acts.examples.root.EffPlotToolConfig() | ||
| # Fake rate Plots | ||
| FakePlotToolConfig = acts.examples.root.FakePlotToolConfig() | ||
| # TrackQuality Plots | ||
| TrackQualityPlotToolConfig = acts.examples.root.TrackQualityPlotToolConfig() | ||
| # Track Summary Plots | ||
| TrackSummaryPlotToolConfig = acts.examples.root.TrackSummaryPlotToolConfig() |
Contributor
There was a problem hiding this comment.
the python scrips are already messy, I fear adding global variables will hurt this even further. I would either use custom addAlgorithm functions on the caller side with the correct params or pass them through names arguments on the high-level add* functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two (largely independent) improvements to the ActsExamples I/O and performance QA code:
EffPlotToolConfig,ResPlotToolConfigetc.) in thereconstruction.py, so binning, pT/eta ranges and other plotting parameters can be configured from .py steering scripts ("full_chain.py") instead of being hard-coded in C++. A small example is added tofull_chain_odd.py.Also,
truthPtRangesForEtaandtruthAbsEtaRangesForPtfromEffPlotToolConfigare now exposed to the python level and can be changed in .py scripts; a log-pT variant of the efficiency-vs-pT plots is added.