Skip to content

feat: Integrate the traccc repository#5471

Open
stephenswat wants to merge 7 commits into
acts-project:mainfrom
stephenswat:feat/traccc
Open

feat: Integrate the traccc repository#5471
stephenswat wants to merge 7 commits into
acts-project:mainfrom
stephenswat:feat/traccc

Conversation

@stephenswat

@stephenswat stephenswat commented May 20, 2026

Copy link
Copy Markdown
Member

This commit incorporates the entire codebase of traccc, the ACTS R&D
line on parallel track reconstruction, into the ACTS project.

The traccc commit used is XXXXXXXXXXXXXXXXXXXXXXXXXXX

--- END COMMIT MESSAGE ---

Confirmed attribution

Co-authored-by: Beomki Yeo <beomki.yeo@gmail.com>
Co-authored-by: Andreas Salzburger <andreas.salzburger@cern.ch>
Co-authored-by: Attila Krasznahorkay <attila.krasznahorkay@cern.ch>
Co-authored-by: Paul Gessinger <paul.gessinger@cern.ch>
Co-authored-by: Joana Niermann <joana.niermann@cern.ch>
Co-authored-by: Guilherme Metelo Rita de Almeida <g.almeida@cern.ch>
Co-authored-by: Neža Ribaric <neza.ribaric@cern.ch>
Co-authored-by: Konrad Kusiak <konrad.kusiak@kx27.eu>
Co-authored-by: Mateusz Jakub Fila <mateusz.jakub.fila@cern.ch>
Co-authored-by: Stewart Martin-Haugh <stewart.martin-haugh@stfc.ac.uk>
Co-authored-by: Xola Gugulethu Mapekula <xola.mapekula@cern.ch>
Co-authored-by: Sylvain Joube <sylvain.joube@gmail.com>
Co-authored-by: Mark Brettell <mark.brettell@cern.ch>
Co-authored-by: Mikkel Mødekjær <mimodekj@cern.ch>
Co-authored-by: Fabrice le Goff <fabrice@legoff.eu>
Co-authored-by: Hadrien Grasland <knights_of_ni@gmx.com>
Co-authored-by: Georgiana Mania <georgiana.mania@gmail.com>
Co-authored-by: Petr Fiedler <petr.fiedler@cern.ch>
Co-authored-by: Gabriel Carmona <gabriel.carmona@phd.unipi.it>
Co-authored-by: Vakho Tsulaia <qiarik@gmail.com>
Co-authored-by: Shima Shimizu <shima.shimizu@cern.ch>
Co-authored-by: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch>
Co-authored-by: Frederik Verdoner Barba <fbarba@ethz.ch>
Co-authored-by: Ioannis Maznas <ioannis.maznas@cern.ch>
Co-authored-by: Carlo Varni <carlo.varni@cern.ch>
Co-authored-by: Sorin Bețișor <inainte2@gmail.com>
Co-authored-by: Sebastián Torrealba <sebastian.torrealba@usm.cl>
Co-authored-by: Abhirikshma Nandi <abhirikshma14@gmail.com>
Co-authored-by: Soumya Sarkar <sosarkar@cern.ch>
Co-authored-by: Ankith Varri <>
Co-authored-by: Chamodya Attanayake <>
Co-authored-by: Arkadijs Slobodkins <>
Co-authored-by: gondiaz <>

Awaiting confirmation

Co-authored-by: ugGit <nwachuch@students.zhaw.ch>
Co-authored-by: ugGit <uchendu.n@hotmail.com>
Co-authored-by: Ryan Cross <ryan.cross@warwick.ac.uk>
Co-authored-by: CrossR <r.cross@lancaster.ac.uk>

--- END COAUTHORS ---

The idea of this PR is to do an as-is copy-paste integration, in order to exactly preserve the existing code base and provide traceability of any bugs we might find in the future.

To do list:

  • Proper attribution of traccc authors.

This commit incurs some technical debt, which is to be solved asap. This includes:

  • Properly integrating the ACTS pre-commit hooks to work on the traccc code.
  • Removing unwanted parts of the traccc code base.

@github-actions github-actions Bot added Infrastructure Changes to build tools, continous integration, ... Component - Documentation Affects the documentation Component - Detray Affects the Detray project labels May 20, 2026
Comment thread thirdparty/traccc/CMakeLists.txt Outdated
Comment thread Traccc/.github/workflows/builds.yml Outdated
@github-actions github-actions Bot added this to the next milestone May 20, 2026
@stephenswat

stephenswat commented May 20, 2026

Copy link
Copy Markdown
Member Author

@Chamodya-ka
@Yhatoh
@arkslobodkins
@guilhermeAlmeida1
@fredevb
@shimasnd

Tagging you all because you have contributed to traccc but you did not use an email. Please let me know if you would like to be attributed with a name and email by replying to this thread.

@stephenswat

Copy link
Copy Markdown
Member Author

@keyradical also you!

@keyradical

Copy link
Copy Markdown

@keyradical also you!

Thanks for the mention, I'm happy to be included with name and email: konrad.kusiak@kx27.eu.

@shimasnd

Copy link
Copy Markdown

Thank you for including me. Name and email for attribution: Shima Shimizu shima.shimizu@cern.ch

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for a23ca6a

Full contents

physmon summary

@stephenswat stephenswat force-pushed the feat/traccc branch 2 times, most recently from 2756cc5 to fca8266 Compare May 21, 2026 07:30
@github-actions github-actions Bot removed Component - Documentation Affects the documentation Component - Detray Affects the Detray project labels May 21, 2026
@Yhatoh

Yhatoh commented May 21, 2026

Copy link
Copy Markdown

@Yhatoh

Thank you Stephen for reaching out, I'm honored. My name is Gabriel Carmona and my email is gabriel.carmona@phd.unipi.it.

@github-actions github-actions Bot added the Component - Detray Affects the Detray project label May 21, 2026
@stephenswat stephenswat force-pushed the feat/traccc branch 2 times, most recently from 985b7b4 to a98b495 Compare May 22, 2026 21:10
@stephenswat

Copy link
Copy Markdown
Member Author

What a glorious day to be alive.

image

@stephenswat stephenswat force-pushed the feat/traccc branch 3 times, most recently from 1d850e2 to 9aa7696 Compare May 27, 2026 14:18
@asalzburger

Copy link
Copy Markdown
Contributor

What's the status on this?

I have noticed, e.g. that traccc doesn't build within ACTS when switching the DETRAY_LOG_LVL to VERBOSE/DEBUG due to some restrict loss of precision compilation error.

      358          TRACCC_VERBOSE_HOST_DEVICE("Actor: Kalman Fitter (status %d)...",
      359 -                                   actor_state.fit_result);
      359 +                                   static_cast<int>(actor_state.fit_result));

Of course these things are way easier to fix in one mono-rep (as I am trying to do with detray where similar issues exist).

@stephenswat

Copy link
Copy Markdown
Member Author

What's the status on this?

What's the status on this?

I have noticed, e.g. that traccc doesn't build within ACTS when switching the DETRAY_LOG_LVL to VERBOSE/DEBUG due to some restrict loss of precision compilation error.

      358          TRACCC_VERBOSE_HOST_DEVICE("Actor: Kalman Fitter (status %d)...",
      359 -                                   actor_state.fit_result);
      359 +                                   static_cast<int>(actor_state.fit_result));

Of course these things are way easier to fix in one mono-rep (as I am trying to do with detray where similar issues exist).

I changed the CI config a bit, so it is now red again but this will be easy to fix. More pressing is to get the 10 open PRs in traccc so we can cleanly merge.

Regarding the logging, that all needs to be turned off for both detray and traccc or you risk running into both compiler warning and runtime segmentation faults.

@niermann999

Copy link
Copy Markdown
Contributor

Regarding the logging, that all needs to be turned off for both detray and traccc or you risk running into both compiler warning and runtime segmentation faults.

Only when you print logs while running on the GPU without rate limiting the output (in my experience at least). Turning the logs on by default should therefore not be done, but especially when running host only code locally we should make sure it it possible to turn it on

@asalzburger

Copy link
Copy Markdown
Contributor

Regarding the logging, that all needs to be turned off for both detray and traccc or you risk running into both compiler warning and runtime segmentation faults.

Only when you print logs while running on the GPU without rate limiting the output (in my experience at least). Turning the logs on by default should therefore not be done, but especially when running host only code locally we should make sure it it possible to turn it on

Exactly, I managed to get it to work - and it's super useful for navigation debugging,

@stephenswat

Copy link
Copy Markdown
Member Author

CI is back to green! 🟢

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
E Reliability Rating on New Code (required ≥ A)
12 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@fredevb

fredevb commented May 30, 2026

Copy link
Copy Markdown
Contributor

@Chamodya-ka @Yhatoh @arkslobodkins @guilhermeAlmeida1 @fredevb @shimasnd

Tagging you all because you have contributed to traccc but you did not use an email. Please let me know if you would like to be attributed with a name and email by replying to this thread.

Happy to be included as Frederik Verdoner Barba fbarba@ethz.ch. Thanks a lot for reaching out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Detray Affects the Detray project Infrastructure Changes to build tools, continous integration, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants