refactor: Exclude the ACTS unittests from detray workflows#5447
refactor: Exclude the ACTS unittests from detray workflows#5447niermann999 wants to merge 5 commits into
Conversation
|
The dummy detray changes were added to trigger the |
3cc3747 to
e89220f
Compare
e89220f to
00d856d
Compare
|
|
Ideally, the traccc plugin workflow should be trimmed down further, is there a way to only run the examples tests? |
| cmake -B build -S . | ||
| --preset=dev | ||
| -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" | ||
| -DCMAKE_BUILD_TYPE="Release" | ||
| -DCMAKE_COMPILE_WARNING_AS_ERROR=ON | ||
| -DCMAKE_CXX_SCAN_FOR_MODULES=OFF | ||
| -DCMAKE_FIND_FRAMEWORK="LAST" | ||
| -DACTS_FORCE_ASSERTIONS=ON | ||
| -DACTS_ENABLE_LOG_FAILURE_THRESHOLD=ON | ||
| -DACTS_USE_SYSTEM_NLOHMANN_JSON=ON | ||
| -DACTS_USE_SYSTEM_PYBIND11=ON | ||
| -DACTS_BUILD_PLUGIN_DD4HEP=ON | ||
| -DACTS_BUILD_PLUGIN_JSON=ON | ||
| -DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON | ||
| -DACTS_BUILD_PLUGIN_TRACCC=ON | ||
| -DDETRAY_GENERATE_METADATA="odd_metadata;itk_metadata" | ||
| -DTRACCC_SUPPORTED_DETECTORS="odd_detector;itk_detector" |
There was a problem hiding this comment.
preset + 15 custom args
con this be trimmed down?
There was a problem hiding this comment.
I hope so. I am not entirely sure what we actually need to set up the geometry conversion and the examples?
| name: Traccc | ||
|
|
||
| # Run whenever detray or traccc are changed. ACTS changes have their own tests |
There was a problem hiding this comment.
not sure if this was discussed already but that setup would mask changes in our usual build so tests and especially physmon cannot be harmonized. I thought we wanted to synchronize this even though I am not sure how this would work with GPU hardware requirements.
There was a problem hiding this comment.
My goal was to extract that code in ACTS that can be affected by changes in detray or traccc into a separate workflow (as far as I know that is right now only the conversion/plugin/example code?) so that it can be triggered by changes in those repositories, without triggering the entire ACTS tests suite (which we know will succeed, but clogs the job queue for quite a while until the (host-)GPU tests get picked up).
Ideally, this would also get triggered by ACTS, but as things are at the moment that would mean just running the same test twice for ACTS, because I did not want to touch the ACTS builds just yet. I am not entirely sure how to best extract these tests from the current ACTS workflow so that it would no longer be a duplicate?
Happy to discuss this
Performance summaryHere is a summary of the performance effects of this PR: Tabular
Note This is an automated message produced upon the explicit request of a human being. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||



Exclude changes in the Detray directory from triggering ACTS builds and instead adding a dedicated plugin build to the detray workflow
--- END COMMIT MESSAGE ---