Skip to content

refactor: Exclude the ACTS unittests from detray workflows#5447

Open
niermann999 wants to merge 5 commits into
acts-project:mainfrom
niermann999:ref-exlude-detray-from-CI
Open

refactor: Exclude the ACTS unittests from detray workflows#5447
niermann999 wants to merge 5 commits into
acts-project:mainfrom
niermann999:ref-exlude-detray-from-CI

Conversation

@niermann999

Copy link
Copy Markdown
Contributor

Exclude changes in the Detray directory from triggering ACTS builds and instead adding a dedicated plugin build to the detray workflow

--- END COMMIT MESSAGE ---

@niermann999 niermann999 changed the title ref: Exclude the ACTS unittests from detray workflows refactor: Exclude the ACTS unittests from detray workflows May 13, 2026
@niermann999

Copy link
Copy Markdown
Contributor Author

The dummy detray changes were added to trigger the traccc-plugin workflow and will be removed before merging. I think, the exclusion cannot be tested here, since the PR itself makes changes to the build.yml?

@github-actions github-actions Bot added this to the next milestone May 13, 2026
@github-actions github-actions Bot added Infrastructure Changes to build tools, continous integration, ... Component - Detray Affects the Detray project labels May 13, 2026
@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for 00d856d

Full contents

physmon summary

@niermann999 niermann999 force-pushed the ref-exlude-detray-from-CI branch 2 times, most recently from 3cc3747 to e89220f Compare May 18, 2026 08:54
@niermann999 niermann999 force-pushed the ref-exlude-detray-from-CI branch from e89220f to 00d856d Compare May 20, 2026 11:44
@niermann999 niermann999 marked this pull request as ready for review May 20, 2026 14:02
@sonarqubecloud

Copy link
Copy Markdown

@niermann999 niermann999 requested a review from andiwand May 21, 2026 12:21
@niermann999

Copy link
Copy Markdown
Contributor Author

Ideally, the traccc plugin workflow should be trimmed down further, is there a way to only run the examples tests?

Comment on lines +64 to +80
cmake -B build -S .
--preset=dev
-DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}"
-DCMAKE_BUILD_TYPE="Release"
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON
-DCMAKE_CXX_SCAN_FOR_MODULES=OFF
-DCMAKE_FIND_FRAMEWORK="LAST"
-DACTS_FORCE_ASSERTIONS=ON
-DACTS_ENABLE_LOG_FAILURE_THRESHOLD=ON
-DACTS_USE_SYSTEM_NLOHMANN_JSON=ON
-DACTS_USE_SYSTEM_PYBIND11=ON
-DACTS_BUILD_PLUGIN_DD4HEP=ON
-DACTS_BUILD_PLUGIN_JSON=ON
-DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON
-DACTS_BUILD_PLUGIN_TRACCC=ON
-DDETRAY_GENERATE_METADATA="odd_metadata;itk_metadata"
-DTRACCC_SUPPORTED_DETECTORS="odd_detector;itk_detector"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preset + 15 custom args

con this be trimmed down?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so. I am not entirely sure what we actually need to set up the geometry conversion and the examples?

Comment on lines +1 to +3
name: Traccc

# Run whenever detray or traccc are changed. ACTS changes have their own tests

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this was discussed already but that setup would mask changes in our usual build so tests and especially physmon cannot be harmonized. I thought we wanted to synchronize this even though I am not sure how this would work with GPU hardware requirements.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal was to extract that code in ACTS that can be affected by changes in detray or traccc into a separate workflow (as far as I know that is right now only the conversion/plugin/example code?) so that it can be triggered by changes in those repositories, without triggering the entire ACTS tests suite (which we know will succeed, but clogs the job queue for quite a while until the (host-)GPU tests get picked up).

Ideally, this would also get triggered by ACTS, but as things are at the moment that would mean just running the same test twice for ACTS, because I did not want to touch the ACTS builds just yet. I am not entirely sure how to best extract these tests from the current ACTS workflow so that it would no longer be a duplicate?

Happy to discuss this

@stephenswat

Copy link
Copy Markdown
Member

Performance summary

Here is a summary of the performance effects of this PR:

Tabular

Benchmark826c9dd00d856dDelta
ThroughputCVThroughputCV
ODD (1 GeV, cov. on)2.38 MHz0.06%2.38 MHz0.06%+0.00%
ODD (1 GeV, cov. off)5.29 MHz0.11%5.29 MHz0.12%-0.02%
ODD (10 GeV, cov. on)3.15 MHz0.04%3.15 MHz0.05%-0.01%
ODD (10 GeV, cov. off)6.60 MHz0.05%6.60 MHz0.05%+0.01%
ODD (100 GeV, cov. on)3.36 MHz0.06%3.36 MHz0.03%-0.02%
ODD (100 GeV, cov. off)6.92 MHz0.03%6.92 MHz0.04%-0.02%
ODD ([1, 100) GeV, cov. on)2.71 MHz0.03%2.71 MHz0.03%-0.00%
ODD ([1, 100) GeV, cov. off)6.06 MHz0.04%6.06 MHz0.02%-0.06%
Toy detector ([1, 100) GeV, cov. on)12.02 MHz0.07%12.03 MHz0.13%+0.04%
Toy detector ([1, 100) GeV, cov. off)18.50 MHz0.03%18.50 MHz0.03%-0.02%
Wire chamber ([1, 100) GeV, cov. on)14.89 MHz0.01%14.89 MHz0.01%-0.01%
Wire chamber ([1, 100) GeV, cov. off)30.28 MHz0.01%30.29 MHz0.02%+0.04%

Note

This is an automated message produced upon the explicit request of a human being.

@andiwand andiwand requested a review from paulgessinger June 5, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Detray Affects the Detray project Infrastructure Changes to build tools, continous integration, ... Needs Discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants