feat: Reimplement as composite action, removing Node.js dependencies - #42
Merged
Conversation
Replace the node20 action with a composite action using bash/pwsh steps directly. The JS wrapper was only reading inputs and shelling out to curl/PowerShell, so no Node.js runtime or npm packages are needed. - Convert action.yml to `using: composite` with bash and pwsh steps - Use env vars for input interpolation (avoids shell injection) - Preserve version-defaulting logic for chef-workstation (21.6.497) - Remove index.js, package.json, package-lock.json - Remove vendored node_modules (200+ files: @actions/core, @actions/exec, undici, etc.) - Add .gitignore to prevent node_modules being committed again Call interface is unchanged for consumers.
damacus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using: node20withusing: composite— bash and pwsh steps call the omnitruck installer directly, exactly as the JS was doingchef-workstationversion default (21.6.497) in shell logicindex.js,package.json,package-lock.json, and all ofnode_modules/(200+ files).gitignoreto preventnode_modules/being committed againThe call interface is unchanged — consumers continue to use
uses: actionshub/chef-install@mainwith the same inputs.Why
The Node.js wrapper was only reading inputs and shelling out to
curl | bash(Linux/macOS) or a PowerShell one-liner (Windows). No npm packages were needed for that. Removing them eliminates:@actions/core,@actions/exec,undici, etc.Test plan
version: latest$GITHUB_PATH)channel: currentand non-defaultprojectvalues