Skip to content

[behavioural_qc] Fix broken links in multilingual LORIS#11010

Open
HachemJ wants to merge 1 commit into
aces:29.0-releasefrom
HachemJ:FixBrokenLinksInBehaviouralQc
Open

[behavioural_qc] Fix broken links in multilingual LORIS#11010
HachemJ wants to merge 1 commit into
aces:29.0-releasefrom
HachemJ:FixBrokenLinksInBehaviouralQc

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes a bug where rowData[...] was undefined when using a language other than English because the row keys were localized (e.g. row['Visit] -> 'undefined' but row['Visite'] -> V1 in French).

Additionally, I added sortByValue: false to the Visit filter in each tab to preserve the correct visit order in the Japanese dropdown, consistent with the change done in the following Media module PR: https://github.com/aces/Loris/pull/10548/changes

Testing instructions (if applicable)

  1. git checkout HachemJ/FixBrokenLinksInBehaviouralQc
  2. Go to 'Clinical' -> 'Behavioural Quality Control'

For tabs 'Incomplete Forms' and 'Data Conflicts', verify that:

  1. The entries in the four following columns (Instrument, DCCID, PSCID and Visit) are displayed as clickable links.
  2. The links remain clickable and navigate to the same URL regardless of the selected language.

For tab 'Behavioural Feedback', verify that:

  1. The entries in the three following columns (DCCID, PSCID, Feedback Level) are displayed as clickable links.
  2. The links remain clickable and navigate to the same URL regardless of the selected language.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: behavioural_qc PR or issue related behavioural_qc module labels Jul 24, 2026
@HachemJ HachemJ changed the title fix broken links in multilingual LORIS behavioural_qc [behavioural_qc] Fix broken links in multilingual LORIS Jul 24, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Module: behavioural_qc PR or issue related behavioural_qc module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant