[imaging_qc] Translate imaging_qc module (non-db translations only) by HachemJ · Pull Request #10966 · aces/Loris

HachemJ · 2026-07-21T14:48:09Z

Brief summary of changes

This PR translates the imaging_qc module in French. It only includes non-db translations (hardcoded in js and php files).

I figured it would be better to separate non-db from db for readability.

Note: I used AI for translations but double-checked them as a French speaker.

Link(s) to related issue(s)

Resolves [imaging_qc] Missing Translations #10782 (Reference the issue this fixes, if any.)

lapadulamichael · 2026-07-22T18:05:57Z

+msgstr "Formulaire des paramètres d'IRM"
+
+msgid "Scan Done in MRI PF"
+msgstr "Scan effectuée dans le formulaire des paramètres d'IRM"


Suggested change

msgstr "Scan effectuée dans le formulaire des paramètres d'IRM"

msgstr "Scan effectué dans le FP d'IRM"

There is a spelling error here. Also, I was wondering if we would maybe want to abbreviate it a lot like it's done in english? It would make it less readable (like the english version) but it would help with the visual aspect of it since its currently much larger then the others.

I don't know honestly. @driusan any thoughts? I don't like the abbreviation in French but it is true that it's way too long on the frontend.

I would probably fix the spelling error only.

I do not have any thoughts. Willing to go with whatever french speakers think is best. It is true that "PF" isn't very readable in English either and it would be consistent.

To be honest idk what PF stands for in the first place. The French translation might be wrong.

In this context it's an abbreviation for "MRI Parameter Form" which was probably abbreviated for the same reason as being discussed of changing it in French.

It is not standard acronym in English either or afaik used anywhere other than here.

Ok I will go with the suggestion to be consistent.

Expanding it in English makes sense to me

Ok it will need code adaptation. @lapadulamichael are you okay with that?

lapadulamichael

Translations look mostly good. A few corrections and maybe a change to abbreviate

lapadulamichael

LGTM

driusan · 2026-07-22T20:21:01Z

+msgid "Scan Type"
+msgstr ""
+
+msgid "MRI Parameter Form"


Little torn on this one. "MRI Parameter Form" refers to a specific instrument that's always used by convention.

Not sure if this belongs here or if it should try and get it from the instruments namespace, or maybe try to instantiate the instrument and call getFullName().

I think for now I'm fine with this being here since changing the code would be pretty significant.

I will skip for now. I have a PR related to these instrument names currently under review https://github.com/aces/Loris/pull/10846/changes#diff-b9e7be736e00021feef06ca5965c6117e127ed6e0ea9f673d4967c7b253d83d8

Let me know what do you think.

… of it and adapting code accordingly + removing space of Session ID for consistency

…ngly

…ranslation files since moved to LORIS namespace

github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: imaging_qc PR or issue related to imaging_qc module Multilingual Any tasks related to making LORIS multilingual labels Jul 21, 2026

HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 21, 2026

lapadulamichael self-assigned this Jul 22, 2026

lapadulamichael self-requested a review July 22, 2026 15:12

lapadulamichael reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/fr/LC_MESSAGES/imaging_qc.po Outdated

lapadulamichael reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/fr/LC_MESSAGES/imaging_qc.po Outdated

lapadulamichael reviewed Jul 22, 2026

View reviewed changes

lapadulamichael assigned HachemJ Jul 22, 2026

lapadulamichael added the State: Needs work PR awaiting additional work by the author to proceed label Jul 22, 2026

HachemJ force-pushed the TranslateImagingQcModule branch from fc5eda4 to 7f2641f Compare July 22, 2026 19:37

HachemJ removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 22, 2026

HachemJ removed their assignment Jul 22, 2026

HachemJ requested a review from lapadulamichael July 22, 2026 19:38

lapadulamichael approved these changes Jul 22, 2026

View reviewed changes

lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jul 22, 2026

driusan reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/fr/LC_MESSAGES/imaging_qc.po Outdated

driusan reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/fr/LC_MESSAGES/imaging_qc.po Outdated

driusan reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/fr/LC_MESSAGES/imaging_qc.po Outdated

driusan reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/imaging_qc.pot Outdated

driusan reviewed Jul 22, 2026

View reviewed changes

Comment thread modules/imaging_qc/locale/imaging_qc.pot Outdated

github-actions Bot added Module: statistics PR or issue related to statistics module Module: mri_violations PR or issue related to mri_violations module labels Jul 22, 2026

HachemJ force-pushed the TranslateImagingQcModule branch from d29778a to 778981e Compare July 22, 2026 21:26

github-actions Bot added Module: issue_tracker PR or issue related to issue tracker module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Jul 22, 2026

HachemJ force-pushed the TranslateImagingQcModule branch from b8fd2f8 to a7a9fd0 Compare July 22, 2026 21:37

HachemJ added 8 commits July 22, 2026 17:51

add non db translations

b368c60

Expand 'MRI PF' into 'MRI Parameter Form' and adapted code accordingly

e65d6e5

moving 'Scan Type' to the LORIS namespace and adapting code accordingly

8d49d4f

moving 'SessionID' to the LORIS namespace, fix the french translation…

2e795bc

… of it and adapting code accordingly + removing space of Session ID for consistency

moving 'Uploaded By' to the LORIS namespace and adapting code accordi…

d3d4eb1

…ngly

moving 'QC Status' to LORIS namespace and adapting code accordingly

b6c6a71

moving 'TarchiveID' to the LORIS namespace and adapting code accordingly

7090d1a

misses: remove unused 'Scan Type' and 'QC Status' from statistics's t…

93ea2a8

…ranslation files since moved to LORIS namespace

HachemJ force-pushed the TranslateImagingQcModule branch from 83f107e to 93ea2a8 Compare July 22, 2026 21:55

HachemJ requested a review from driusan July 23, 2026 13:43

driusan merged commit 0db58db into aces:29.0-release Jul 23, 2026
22 checks passed

	msgstr "Scan effectuée dans le formulaire des paramètres d'IRM"
	msgstr "Scan effectué dans le FP d'IRM"

Uh oh!

Conversation

HachemJ commented Jul 21, 2026

Brief summary of changes

Link(s) to related issue(s)

Uh oh!

Uh oh!

lapadulamichael Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

driusan Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lapadulamichael left a comment

Choose a reason for hiding this comment

Uh oh!

lapadulamichael left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lapadulamichael Jul 22, 2026 •

edited

Loading

driusan Jul 22, 2026 •

edited

Loading