[redcap] Add redcap{@}true to imported REDCap instruments meta#10926
[redcap] Add redcap{@}true to imported REDCap instruments meta#10926MaximeBICMTL wants to merge 1 commit into
redcap{@}true to imported REDCap instruments meta#10926Conversation
redcap{@}true to imported REDCap instruments metaredcap{@}true to imported REDCap instruments meta
regisoc
left a comment
There was a problem hiding this comment.
Pretty simple, but is there no logic associated with this?
E.g. Instrument method to filter REDCap instruments.
|
Nope I don't know the REDCap-specific logic that @ridz1208 needs, but this can be added in a later PR. In any case it makes sense to have a marker to differentiate REDCap and non-REDCap instruments. |
|
I don't think it makes sense to have this without the code changes to go with it. If it's a CBIGR override, it should have code changes that go along with it? There's no point in having a flag that's unused.. it also won't be brought along with instruments that are uploaded from the instrument uploader since it's in the meta file and not the linst file. |
|
Hhhm, this PR is not blocking for me so no biggie if not merged. But if I look at it as a standalone, I still think it is valuable addition to the REDCap module. The REDCap-specific code seems to be implemented in #9472 (https://github.com/aces/CBIGR/pull/463 on C-BIG). However, the point of this PR is to provide an answer to "was this instrument imported from REDCap", which AFAIK is currently not possible to answer and is IMO a valuable distinction. To do so, I think adding the
Also, merging this PR somewhat early (before eventual code changes) allows more newly imported instruments to have this flag, preventing us from needing to go back and edit already imported instruments to add the flag manually as we've done on C-BIG. Anyway, as I said this PR is not blocking for me, so feel free to move it to LORIS 30 or close it you prefer. |
|
@driusan @MaximeBICMTL I'm neither here nor there on this one, I do see value in having the flag on it's own but there are some extremely low hanging fruit code changes that could be made alongside it.
|
|
Ohokay, I was not aware of which exact changes used this flag, I can definitely add those to this PR though. Just need to decide whether to include this on 29 or not, but note that I don't have access to a REDCap instance right now (token expired, need project to update, hence also why I am not reviewing other REDCap PRs 😬). |
|
@MaximeBICMTL please add these little changes and make it to 29 merci |
Implementation of https://github.com/aces/CBIGR/issues/831
Differentiate REDCap instruments from non-REDCap instruments by adding
redcap{@}trueto the formers meta file.