Skip to content

[api] Add missing error translations in french#10873

Open
HachemJ wants to merge 3 commits into
aces:29.0-releasefrom
HachemJ:AddMissingErrorTranslationsInApi
Open

[api] Add missing error translations in french#10873
HachemJ wants to merge 3 commits into
aces:29.0-releasefrom
HachemJ:AddMissingErrorTranslationsInApi

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR adds missing error translations in french for the api module.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: api PR or issue related to api module Multilingual Any tasks related to making LORIS multilingual labels Jul 11, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 11, 2026

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jul 15, 2026
@HachemJ

HachemJ commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review once again. After taking one last look at the PR, I found a few unintended changes. I will revert them in a final commit.

image

This is something I have reverted from multiple PRs after Jefferson brought it up Monday during the PR assignment/working session meeting while reviewing one of my PRs. $e->getMessage() contains messages from LORIS exceptions, which are not yet translated. They will be translated in a future PR under the loris namespace. Until then, translating $e->getMessage() directly isn’t appropriate because its value is dynamic and cannot be known ahead of time.

@lapadulamichael

Copy link
Copy Markdown
Contributor

I see, that makes sense. I will wait for your changes and re-review

@lapadulamichael
lapadulamichael self-requested a review July 15, 2026 16:41
@lapadulamichael lapadulamichael removed the Passed manual tests PR has been successfully tested by at least one peer label Jul 15, 2026
@@ -0,0 +1,184 @@
# Default LORIS strings to be translated (English)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think API strings should be translated. (It's debateable if they should be considered code that third party tools depend on the exact response or whether they should be considered as messages that are shown to the user, but in the short term I think it's best to not translate them)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10624

I don't know what to do about this issue then because the error clearly comes from the api module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: PHP PR or issue that update PHP code Module: api PR or issue related to api module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants