[api] Add missing error translations in french#10873
Open
HachemJ wants to merge 3 commits into
Open
Conversation
Open
28 tasks
Contributor
Author
Contributor
|
I see, that makes sense. I will wait for your changes and re-review |
lapadulamichael
self-requested a review
July 15, 2026 16:41
driusan
reviewed
Jul 20, 2026
| @@ -0,0 +1,184 @@ | |||
| # Default LORIS strings to be translated (English) | |||
Collaborator
There was a problem hiding this comment.
I don't think API strings should be translated. (It's debateable if they should be considered code that third party tools depend on the exact response or whether they should be considered as messages that are shown to the user, but in the short term I think it's best to not translate them)
Contributor
Author
There was a problem hiding this comment.
I don't know what to do about this issue then because the error clearly comes from the api module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brief summary of changes
This PR adds missing error translations in french for the api module.
Link(s) to related issue(s)