Repository navigation
Centre the disk image's icons on the new background's arrow - #2316
Merged
Merged
Conversation
The new background (2026-10-01) draws the drag arrow 44 points further right, 88 pixels on the @2x image, centred at x=479. The app and the Applications link move with it, from (260, 290) and (610, 290) to (304, 290) and (654, 290), the layout VLEAPP already uses. A test now finds the arrow on dmg_background.png and requires the two icons to straddle it, so a background that moves the arrow again fails in the test suite rather than on a Mac. The 1x background is the @2x reduced to 960x540; tiffutil -cathidpicheck accepts the pair. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new disk image background draws the drag arrow 44 points further right: 88 pixels on the @2x image, with its centre now at x=479. The app and Applications icons move with it, from (260, 290) and (610, 290) to (304, 290) and (654, 290).
packaging/dmg_background@2x.pngis the new background at 1920x1080.packaging/dmg_background.pngis that same image reduced to 960x540.tiffutil -cathidpicheckaccepts the pair.packaging/dmg_settings.pyhas the new icon positions.test_the_icons_sit_either_side_of_the_arrow, finds the arrow on the 1x background and requires the two icons to sit either side of it. If a future background moves the arrow, this test fails instead of the problem only showing up on a Mac. It fails with the old positions..claude/rules/ileapp-build-and-release.mddescribes the move.🤖 Generated with Claude Code