Read Snapchat user.plist values only where they follow their key - #2246
Merged
Merged
Conversation
A key with no value in user.plist is followed by a single 0x00, as on a signed-out account's file. The reader took the next string in the file as the value, so the Account artifact reported username as "user_id". A value now has to begin where its key ends. Output on the tested user.plist files is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes how
Snapchat - Accountreads a key with no value. In a signed-out account's user.plist the key is followed by a single 0x00, and the reader took the next string in the file instead, so it reported username asuser_id. A value now has to begin where its key ends.test_snapchat_tsaf_values.pycovers a signed-in file, a signed-out file and a single empty value.Reported by dfjsim (Snapchat_Auto).
🤖 Generated with Claude Code