Keep a conversation view's data values as the artifact wrote them - #2233
Merged
Merged
Conversation
lava_process_artifact turned every data_views value that matched a column header into that column's SQL name. Two of those keys carry data rather than a column name: LAVA reads directionSentValue and sentMessageStaticLabel as written and resolves every other key to a column. So a direction value of 'Sent' beside a 'Sent' time column reached the manifest as 'sent', no row matched it, and LAVA's conversation view showed every message as received. Those two keys now pass through unchanged, and column keys are sanitized as before. No shipped artifact's manifest changes: none of the 103 conversation views across the five tools uses a sent value or a static label that matches one of its own headers. The new test fails on three of its five cases against the old writer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes conversation views in LAVA.
Adds admin/test/scripts/test_lava_conversation_view_values.py, which fails on three of its five cases against the old writer.
🤖 Generated with Claude Code