Remove media_to_html - #2226
Merged
Merged
Remove media_to_html#2226
Conversation
The Attachment column used media_to_html, which built its link from the examiner's folder names: an output folder with "data" in a parent folder's name produced a broken link carrying those names. It also matched a video by file name in any app container, and the TSV and LAVA rows got nothing. The video is now checked in with check_in_media in a media column, looked up only in the database's own container's Movies folder. HTML, TSV and LAVA all carry it. The notes record what hexordia_ios1651 holds (the app's database with no video rows) and that the link has only been exercised on constructed data. The HTML safety check's exception for this module is no longer needed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
No artifact calls media_to_html any more. It returned a full path unchanged when it could not find the file, and could build its links from the examiner's own folder names. It is removed from ilapfuncs.py along with what existed only for it: the allow_parent option of safe_local_path, which only it passed, so a report path can no longer climb out of the report folder with "..", its entries in check_html_safety.py, and the check_report_local_paths.py rule and tests that modelled it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes media_to_html from ilapfuncs.py now that nothing calls it.
The same removal is in abrignoni/ALEAPP#1419, abrignoni/RLEAPP#489, abrignoni/VLEAPP#229 and abrignoni/DLEAPP#189.
🤖 Generated with Claude Code