Re-vendor qnxprobe 1.29 (F2FS NAT copy selection fix) - #2179
Merged
Conversation
…are read qnxprobe 1.29 (abrignoni/qnxprobe 10b1add) fixes a defect in the 1.28 copy this replaces: the bitmap that says which of two copies of each NAT block is current was read least-significant-bit-first, but F2FS writes it the other way round. On an F2FS volume whose NAT blocks have been rewritten, 1.28 resolves node ids through the stale copy, and upstream measured it finding no files at all on a volume the kernel wrote twice where the kernel reads 44. -t raw on such an image is affected, so the copy is worth taking even though the release's other half, free-space reporting for a scoped carve, has no caller here. Vendored file and manifest only. The 24 raw-image seeker tests pass and the vendoring check passes against the pinned upstream. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-vendors qnxprobe at 1.29. The reason to take it is a fix to the 1.28 copy this replaces: the bitmap that says which of two copies of each NAT block is current was read least-significant-bit-first, and F2FS writes it most-significant-bit-first. On an F2FS volume whose NAT blocks have been rewritten, 1.28 resolves node ids through the stale copy. Upstream measured 1.28 finding no files at all on a volume the kernel wrote twice, where the kernel reads 44.
scripts/vendor/qnxprobe.pyat10b1add, manifest updated; the vendoring check passes against the pinned upstream.The 24 raw-image seeker tests pass.
🤖 Generated with Claude Code