Type the timestamp columns of the cloud service and snapshot artifacts - #2175
Merged
Conversation
Ph085 and Ph086 returned TimestampUTC as an untyped header holding datetime objects, as did get_snapshot_creationDate for Creation Date, Expiration Date and Last Used Date and get_snapshot_lastUsedDate for Expiration Date, so LAVA stored those values as text rather than as timestamps. They are now typed datetime, and get_snapshot_lastUsedDate compares header names so the typed tuples still line up. The Ph085 and Ph086 descriptions now cite the Scott Koenig post that documents cloudServiceEnableLog.plist and say the plist records enabling and disabling. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types the timestamp columns of four artifacts as datetime.
These columns carry datetime values under untyped headers, so LAVA stored them as text rather than as timestamps. HTML and TSV output is unchanged, and empty values stay empty. The Ph085 and Ph086 descriptions now cite the Scott Koenig post that documents the plist and say it records enabling and disabling.
🤖 Generated with Claude Code