Bind date and datetime values as text in the SQLite writers - #2174
Merged
Conversation
lava_insert_sqlite_data, lava_insert_sqlite_media_item and kmlgen passed date and datetime objects straight to sqlite3, which converts them through default adapters that are deprecated as of Python 3.12 and warn on every value. The new lavafuncs.bind_dates_as_text returns str(value) for those objects, which is exactly the text the adapters wrote, isoformat(" ") for a datetime and isoformat() for a date, so the stored text does not change. admin/test/scripts/test_sqlite_date_binding.py pins both the stored text and the absence of the warning.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binds date and datetime values as text in the LAVA and KML writers.
lavafuncs.bind_dates_as_textreturnsstr(value)for a date or datetime, which is the text sqlite3's default adapters wrote:isoformat(" ")for a datetime andisoformat()for a date.lava_insert_sqlite_data,lava_insert_sqlite_media_itemandkmlgenbind through it, so those writes no longer use the default adapters Python 3.12 deprecated.admin/test/scripts/test_sqlite_date_binding.pypins the stored text and checks that no adapter warning is raised.Columns typed
datetimeare not affected. They were already converted to epoch values before binding.Same change in ALEAPP #1399, RLEAPP #468, VLEAPP #209, DLEAPP #129.
🤖 Generated with Claude Code