Name KML placemarks by timestamp in two location artifacts - #2172
Merged
Conversation
wifiAnalyticsGeotags and personalizationPortraitLocations returned their timestamps as SQL datetime() strings. kmlgen names a placemark after a Timestamp column or the first datetime value in the row, so every placemark in both KML exports was named N/A. The timestamps now come from convert_cocoa_core_data_ts_to_utc and convert_unix_ts_to_utc, so each placemark is named by the record's first timestamp, and the timestamp text in the HTML, TSV and timeline gains +00:00. wifiAnalyticsGeotags also drops Entity ID. It was ZGEOTAG.Z_ENT, the Core Data entity number, and held a single value on every tested store. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names KML placemarks by timestamp in two location artifacts.
Row counts and LAVA epochs are unchanged. Timestamp text in the HTML, TSV and timeline now ends in +00:00.
🤖 Generated with Claude Code