Report a Source column that another column already separates - #254
Merged
Merged
Conversation
check_artifact_output.py gains a source-column finding: a Source File, Source Path, Source Folder or Source Database column where another column pairs one to one with the files, each file on at least two rows. The located-at line and the LAVA source_path already name every file read, so the column may repeat what the other one says. A match on one image can be a coincidence, so the finding is silenced by a notes sentence naming both columns and saying why the Source column stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a source-column finding to check_artifact_output.py. It fires when a Source File, Source Path, Source Folder or Source Database column names two or more files, each file has at least two rows, and another column pairs one to one with the files.
The checker and its tests are byte-identical across the five cores.
🤖 Generated with Claude Code