Do not walk a socket or block device as a directory, and re-vendor qnxprobe 1.34 - #250
Merged
Merged
Conversation
…seeker The seeker decided a directory with `mode & S_IFDIR`. S_IFDIR is 0o040000, and a socket (0o140000) and a block device (0o060000) carry that bit too, so both were listed as directories and walked into. On the public macOS Big Sur acquisition that was 47 sockets under private/var. It now tests the format bits, `mode & S_IFMT == S_IFDIR`, as the vendored qnxprobe does. The new test gives the seeker a socket and a block device that each claim a child, and requires neither to be listed or walked. It fails on the old line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nothing On a Python without zstd, qnxprobe 1.34 carries the reason as the volume's note, and this seeker prints a volume's note on its line in the run log. The raw-image doc said the log gave no reason; it now says the log names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The seeker's walk never reads a file, and its unused arguments were two new pylint warnings in the lint gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
mode & S_IFDIRalone. It now tests the format bits, as qnxprobe does. On the public macOS Big Sur acquisition this removes 47 sockets listed as directories under private/var; the member lists of five other public acquisitions are unchanged. New test fails on the old line.🤖 Generated with Claude Code