Skip to content

Follow a path through media_to_html in check_report_local_paths - #228

Merged
abrignoni merged 1 commit into
mainfrom
fix/media-to-html-local-path-check
Sep 19, 2026
Merged

abrignoni merged 1 commit into
mainfrom
fix/media-to-html-local-path-check

Conversation

@abrignoni

Copy link
Copy Markdown
Owner

Brings check_report_local_paths.py and its test level with abrignoni/iLEAPP#2223.

  • media_to_html returns any full path it is given unchanged, so a path passed to it reached the row verbatim. The check now follows the taint of its first argument through the call.
  • Tests pin the positional and keyword forms, a file name read from a database, and the check_in_embedded_media fix, which must stay silent.
  • No artifact here calls media_to_html. The check passes on this repo, and both files match the iLEAPP change byte for byte.

🤖 Generated with Claude Code

media_to_html returns its first argument unchanged unless it is a bare file
name found in files_found, so a full path handed to it reaches the row
verbatim. iLEAPP's Photos.sqlite face crop artifacts published the report
folder that way and the check did not see it. The check now carries the
taint of that first argument through the call. No artifact in this repo
calls media_to_html, so it stays green here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@abrignoni
abrignoni merged commit 697ade4 into main Sep 19, 2026
8 checks passed
@abrignoni
abrignoni deleted the fix/media-to-html-local-path-check branch September 19, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant