Drop the Source File column where it repeats one path on every row - #218
Merged
Merged
Conversation
abrignoni
force-pushed
the
chore/drop-redundant-source-file-column
branch
from
September 17, 2026 15:40
5f92ad8 to
464489f
Compare
Levels the DLEAPP #175 change into VLEAPP. An artifact's third return element already carries the evidence location: it becomes the report's "located at" line and the LAVA manifest source_path, which is what the artifact information modal shows. When an artifact reads a single file, a per-row Source File column repeats that same path on every row and adds nothing the modal did not. Removes the column from the three ford_power_history artifacts. The Ford logical corpus holds exactly one reset-history.txt, and the two sibling artifacts read a single last-shutdown.txt and reset-reason.txt through the shared _POWER_HEADERS, which the checker cannot read statically but which are redundant for the same reason. berla_ive_export is deliberately left alone: an iVe export can describe more than one vehicle, and that artifact joins several source paths, so its column can legitimately differ between rows. Adds admin/scripts/check_source_file_column.py, byte-identical with the other cores, and wires it into python_lint. It flags only a path anchored at a directory that exists once per machine, so anything it cannot prove keeps its column: a wrongly removed column costs per-row attribution, a wrongly kept one costs a repeated cell. Validated with validate_sample_data --run against ford_syncg4_logical: every artifact compared against the LAVA manifest, 0 errors and 0 warnings, so the recorded row counts are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
abrignoni
force-pushed
the
chore/drop-redundant-source-file-column
branch
from
September 17, 2026 15:44
464489f to
c00d62f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Levels DLEAPP #175 into VLEAPP.
An artifact's third return element already carries the evidence location: it becomes the report's "located at" line and the LAVA manifest
source_path, which is what the artifact information modal shows. So when an artifact reads a single file, a per-row Source File column repeats that same path on every row and adds nothing the modal did not already give.Removes the column from the three
ford_power_historyartifacts. The Ford logical corpus holds exactly onereset-history.txt, and the two siblings read a singlelast-shutdown.txtandreset-reason.txtthrough the shared_POWER_HEADERS, which the checker cannot read statically but which are redundant for the same reason.berla_ive_exportis deliberately left alone: an iVe export can describe more than one vehicle and that artifact joins several source paths, so its column can legitimately differ between rows.Adds
admin/scripts/check_source_file_column.py, byte-identical with the other cores, wired into python_lint. It flags only a path anchored at a directory that exists once per machine, so anything it cannot prove keeps its column. That asymmetry is deliberate: a wrongly removed column costs per-row attribution, a wrongly kept one costs a repeated cell.Validated with
validate_sample_data --runagainstford_syncg4_logical: 25 artifacts compared against the LAVA manifest, 0 errors and 0 warnings, so the recorded row counts are unchanged.🤖 Generated with Claude Code